Bug 16089

Summary: [855GM] hang at startup
Product: xorg Reporter: CIJOML CIJOMLovic CIJOMLov <cijoml>
Component: Driver/intelAssignee: Jesse Barnes <jbarnes>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: major    
Priority: medium CC: eric, michael.fu
Version: gitKeywords: NEEDINFO
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Xorg.0.log-bad
none
Xorg.0.log-good none

Description CIJOML CIJOMLovic CIJOMLov 2008-05-24 19:35:56 UTC
Hi there,

I upgraded from my last working commit version 

commit f69b48fe24ef94dac44b8123884ca71df675be4b
Author: Jesse Barnes <jbarnes@hobbes.virtuousgeek.org>
Date:   Tue Dec 18 18:10:33 2007 -0800

    Unconditionally restore pipe configuration

    This is a partial fix for #13196, which covers both leaving pipes disabled at
    server exit time and problems with restoring the pipe configuration on certain
    chipsets.  It restores the pipe configuration unconditionally (previously we
    made sure the PLL was running and we weren't in VGA mode) but also adds some
    additional PLL settle time to the PLL register write paths.
------------

to today's (20080524) git version and now my xorg crashes computer almost everytime when it starts. If not imeditially, so imeditially after switch to fb console.

I made git bisect, but last 3 bads are because problem compiling kernel.
Here is the log:
----------
git-bisect start
# bad: [165c0865d849b7d280a3a119fe9ae0ad34637df0] Define DEFFILEMODE for OS'es that don't have it
git-bisect bad 165c0865d849b7d280a3a119fe9ae0ad34637df0
# good: [f69b48fe24ef94dac44b8123884ca71df675be4b] Unconditionally restore pipe configuration
git-bisect good f69b48fe24ef94dac44b8123884ca71df675be4b
# good: [31654f52b084ebb32f69854dfb1c342c9da07928] Merge branch 'master' into xvmc
git-bisect good 31654f52b084ebb32f69854dfb1c342c9da07928
# bad: [dcbdc901d64d2fab489292ef1c9ca1490bdd1e94] Merge commit 'origin/master' into projective-965
git-bisect bad dcbdc901d64d2fab489292ef1c9ca1490bdd1e94
# bad: [5fcc002f77ebb66c1dc0f901a377ccf9bbc1d0bd] Fix crash triggered by dpms low power mode with hardware overlay running
git-bisect bad 5fcc002f77ebb66c1dc0f901a377ccf9bbc1d0bd
# good: [f425181695b1b3864373e1919cf651229f19fa69] Merge branch 'master' into xvmc
git-bisect good f425181695b1b3864373e1919cf651229f19fa69
# bad: [03ccffd5b9b8108166ea143884a1a0a6417f3236] Merge branch 'master' into xvmc
git-bisect bad 03ccffd5b9b8108166ea143884a1a0a6417f3236
# bad: [69fbc17441d0f894d17b058e65ae22300cd2a54c] Change OUT_RING and similar calls to OUT_BATCH for batchbuffer merge
git-bisect bad 69fbc17441d0f894d17b058e65ae22300cd2a54c
# bad: [402fbd36221d2ed27913850f6bfcce768b970fe8] Remove fbc enable/disable messages
git-bisect bad 402fbd36221d2ed27913850f6bfcce768b970fe8
-----
Thanks for fixing ASAP

Michal
Comment 1 CIJOML CIJOMLovic CIJOMLov 2008-05-24 19:38:03 UTC
sorry problem compiling source.
Comment 2 Gordon Jin 2008-05-25 19:29:10 UTC
(In reply to comment #1)
> sorry problem compiling source.

Do you mean this bug report is invalid as a compiling issue? Or could you git-bisect to the exact culprit commit?

btw, I'm not seeing this issue with the latest driver.
Comment 3 CIJOML CIJOMLovic CIJOMLov 2008-05-28 13:20:24 UTC
Hi there,

I finally found commit causign complete computer freeze at my configuration bisecting tree:

notas:/usr/src/xf86-video-intel# git bisect log
git-bisect start
# bad: [363ccc3dfbf8ab91608d502e0376a43653581856] Fixup FIFO comment
git-bisect bad 363ccc3dfbf8ab91608d502e0376a43653581856
# good: [b2726899bc6ebd108aa4a5dd66fe1d881bb778b3] Add more FBC regs
git-bisect good b2726899bc6ebd108aa4a5dd66fe1d881bb778b3
# good: [31654f52b084ebb32f69854dfb1c342c9da07928] Merge branch 'master' into xvmc
git-bisect good 31654f52b084ebb32f69854dfb1c342c9da07928
# bad: [dcbdc901d64d2fab489292ef1c9ca1490bdd1e94] Merge commit 'origin/master' into projective-965
git-bisect bad dcbdc901d64d2fab489292ef1c9ca1490bdd1e94
# good: [5fcc002f77ebb66c1dc0f901a377ccf9bbc1d0bd] Fix crash triggered by dpms low power mode with hardware overlay running
git-bisect good 5fcc002f77ebb66c1dc0f901a377ccf9bbc1d0bd
# bad: [771a56b1ed0df69345c723cb62a73b6842cd8227] Clarify comment in exa_sf program
git-bisect bad 771a56b1ed0df69345c723cb62a73b6842cd8227
# bad: [588371ba15afffa9343629f0ea7ce530586eef0b] Merge branch 'master' into pfit
git-bisect bad 588371ba15afffa9343629f0ea7ce530586eef0b
# bad: [8cdbd55f8075cd18b563badde35815665d7d053e] Fix 965+ rendering issues with DRI disabled.
git-bisect bad 8cdbd55f8075cd18b563badde35815665d7d053e
# bad: [552a1b824db31a234d7c5cb71057ed0e0ce64477] Disable a bunch of clock gating disables on IGD_GM, which doesn't need them.
git-bisect bad 552a1b824db31a234d7c5cb71057ed0e0ce64477
# good: [c1a2bc357fc122d3718eca771530367ba2915815] Don't try to build XvMC if DRI is disabled
git-bisect good c1a2bc357fc122d3718eca771530367ba2915815
notas:/usr/src/xf86-video-intel#


The one which causes problems is:
# bad: [552a1b824db31a234d7c5cb71057ed0e0ce64477] Disable a bunch of clock gating disables on IGD_GM, which doesn't need them.

Can anybody remove it from tree or solve problem it caused?

Thanks a lot

Michal
Comment 4 Eric Anholt 2008-05-28 15:04:26 UTC
Do you actually have the hardware that the commit in question affects?
Comment 5 Gordon Jin 2008-05-28 18:38:05 UTC
Could you attach Xorg.0.log? That commit only impacts a specific hardware, and I suspect it's probably not the one you are using.
Comment 6 CIJOML CIJOMLovic CIJOMLov 2008-05-28 23:45:47 UTC
Hi Gordon,

my hardware is Acer TravelMate 242 with Intel 852GME.
Comment 7 Eric Anholt 2008-05-29 12:08:53 UTC
Then I don't see any possible way it could be the commit you bisected to.
Comment 8 CIJOML CIJOMLovic CIJOMLov 2008-05-29 12:14:15 UTC
Don't ask me how bisect works - but now it runns again...I will add log from successful start with version I bisected and with latest git which crashes my computer. Give me sec...
Comment 9 Michael Fu 2008-06-05 06:06:24 UTC
response? Michal?
Comment 10 CIJOML CIJOMLovic CIJOMLov 2008-06-05 11:12:14 UTC
Created attachment 16936 [details]
Xorg.0.log-bad

Xorg.0.log-bad taken with while true; do sync;done & at the background, hopefully almost complete
Comment 11 CIJOML CIJOMLovic CIJOMLov 2008-06-05 11:12:45 UTC
Created attachment 16937 [details]
Xorg.0.log-good

Xorg.0.log-good
Comment 12 Michael Fu 2008-06-22 22:34:45 UTC
anything fishy from the log, zhenyu? is there any other info or action we can ask michal to do?
Comment 13 Wang Zhenyu 2008-06-22 23:53:26 UTC
So 2.3.1 and 2.3.2 works for you, but git master failed? I think it's still FIFO issue we haven't resolved so far.
Comment 14 Michael Fu 2008-07-09 23:46:15 UTC
re-assign to Jesse. 
Comment 15 Jesse Barnes 2008-07-17 13:51:03 UTC
If it really is a FIFO issue, the latest patch in 16169 might help.  Can you give it a try?
Comment 16 Jesse Barnes 2008-07-17 13:51:51 UTC
Oh, you'll need to apply the patch to git master too, it has some other fixes for 855 as well.
Comment 17 Jesse Barnes 2008-08-20 13:16:28 UTC
I'm pretty sure we've fixed this one, please re-open if that's not the case, Michael.

Thanks,
Jesse

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.