Bug 15382

Summary:

Patches for dri2 linux-core

Product:

DRI

Reporter:

Roland "Test-tools" Bär <roland>

Component:

DRM/other

Assignee:

Default DRI bug account <dri-devel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

high

CC:

roland, thomas

Version:

XOrg git

Keywords:

janitor, patch

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
Null check order fixes, uninit	none
KERNEL_VERSION() was forgotten	none

Description Roland "Test-tools" Bär 2008-04-07 01:56:59 UTC

Created attachment 15732 [details] [review]
Null check order fixes, uninit

Hello,

the first patch sets fixes dereferences before NULL check problems,
ans an probably uninit variable.
The 2nd adds forgotten KERNEL_VERSION macro.

Please apply attached patches

Roland "Test-tools" Bär

Comment 1 Roland "Test-tools" Bär 2008-04-07 01:57:35 UTC

Created attachment 15733 [details] [review]
KERNEL_VERSION() was forgotten

Comment 2 Shuang He 2008-04-07 18:28:34 UTC

I met this problem as well. the 2nd patch works for me.
this problem is brought in by following commit:

commit c3888b97f60fbbc0b1382e5a16689eecaa2f79a5
Author: Thomas Hellstrom <thomas-at-tungstengraphics-dot-com>
Date:   Sun Apr 6 10:32:02 2008 +0200

    Use clflush() when available for cache flushing.

Comment 3 Thomas Hellström 2008-04-07 23:43:51 UTC

(In reply to comment #2)
> I met this problem as well. the 2nd patch works for me.
> this problem is brought in by following commit:
> 
> commit c3888b97f60fbbc0b1382e5a16689eecaa2f79a5
> Author: Thomas Hellstrom <thomas-at-tungstengraphics-dot-com>
> Date:   Sun Apr 6 10:32:02 2008 +0200
> 
>     Use clflush() when available for cache flushing.
> 

And should be fixed with Patrice Mandin's commit of the above patch, right?

/Thomas

Comment 4 Shuang He 2008-04-07 23:51:50 UTC

(In reply to comment #3)
> (In reply to comment #2)
> > I met this problem as well. the 2nd patch works for me.
> > this problem is brought in by following commit:
> > 
> > commit c3888b97f60fbbc0b1382e5a16689eecaa2f79a5
> > Author: Thomas Hellstrom <thomas-at-tungstengraphics-dot-com>
> > Date:   Sun Apr 6 10:32:02 2008 +0200
> > 
> >     Use clflush() when available for cache flushing.
> > 
> 
> And should be fixed with Patrice Mandin's commit of the above patch, right?
> 
> /Thomas
> 

yeah, it's fixed.

Comment 5 Roland "Test-tools" Bär 2008-04-08 00:47:55 UTC

Comment on attachment 15733 [details] [review]
KERNEL_VERSION() was forgotten

Patch 2 fixed, obsoleted.
Patch 1 still open.

Comment 6 Roland "Test-tools" Bär 2008-04-08 03:53:57 UTC

Comment on attachment 15732 [details] [review]
Null check order fixes, uninit

Have to redo this...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.