Bug 15163

Summary: error when sending dict with dbus-send
Product: dbus Reporter: Jérémie Dimino <jeremie>
Component: coreAssignee: Havoc Pennington <hp>
Status: RESOLVED FIXED QA Contact: John (J5) Palmieri <johnp>
Severity: minor    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: All   
OS: All   
i915 platform: i915 features:
Attachments: Patch to correctly send dict with dbus-send

Description Jérémie Dimino 2008-03-21 12:07:38 UTC
Created attachment 15381 [details] [review]
Patch to correctly send dict with dbus-send


I was playing with dbus-send when i noticed a problem with sending dict. There is an assertion failed in dbus_message_iter_open_container and the dict is not added to the message.

I made a small patch to correct it.
Comment 1 John (J5) Palmieri 2008-04-03 08:39:00 UTC
Thanks, since this patch was a big catch and the patch a bit above just the normal bug fix I have added you to the AUTHORS file.  Feel free to submit support for structs too :-)

BTW. your patch was a reverse patch.  Your original and modified sources were swapped so it look like you removed the code instead of adding it.  The best way to do a patch in git is to commit your changes to your local tree and use git-format-patch.  That will get me your commit message and make it easier for me to add to my tree.
Comment 2 John (J5) Palmieri 2008-04-04 11:47:29 UTC
Hmm, ok perhaps the patch was correct but it was already applied and this bug not close :-)  Woops, need to revert.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.