Bug 15049

Created attachment 15169 [details] [review]
0001-Compile-warning-fixes.patch

Minor changes to avoid declarations mixed with code.
  Ansified functions with empty prototype to specify they don't
receive arguments.
  Added some prototypes to radeon.h, and major reorder on radeon.h
adding prototypes in alphabetical order and specifying to file that
defines it.

  Remaining warnings are about pointer of type 'void *' used in arithmetic,
and no changes were done to AtomBios code, i.e. it still has a lot of
missing prototypes, but this should be done in another step, as there are
several functions with "promotable" arguments, but apparently they have
an declaration of the function before usage, just that the definition
doesn't include any header with the prototype.

-
  This patch got big enough so I did not try to make any changes to
atombios related code. Please review.

  Remaining warnings are:
radeon_render.c:432: warning: pointer of type 'void *' used in arithmetic
radeon_render.c:772: warning: pointer of type 'void *' used in arithmetic
radeon_render.c:432: warning: pointer of type 'void *' used in arithmetic
radeon_render.c:772: warning: pointer of type 'void *' used in arithmetic
radeon_cursor.c:234: warning: pointer of type 'void *' used in arithmetic
radeon_cursor.c:234: warning: pointer of type 'void *' used in arithmetic
radeon_cursor.c:277: warning: pointer of type 'void *' used in arithmetic
radeon_cursor.c:277: warning: pointer of type 'void *' used in arithmetic
radeon_driver.c:5198: warning: pointer of type 'void *' used in arithmetic
radeon_driver.c:5251: warning: pointer of type 'void *' used in arithmetic
radeon_video.c:3038: warning: pointer of type 'void *' used in arithmetic
radeon_textured_videofuncs.c:96: warning: pointer of type 'void *' used in subtraction
radeon_textured_videofuncs.c:96: warning: pointer of type 'void *' used in subtraction
radeon_textured_video.c:224: warning: pointer of type 'void *' used in arithmetic
radeon_textured_video.c:224: warning: pointer of type 'void *' used in arithmetic
radeon_crtc.c:452: warning: pointer of type 'void *' used in arithmetic
./AtomBios/includes/CD_Common_Types.h:76: warning: ignoring #pragma warning 
./AtomBios/includes/CD_Common_Types.h:150: warning: ignoring #pragma warning 
AtomBios/CD_Operations.c:215: warning: no previous prototype for 'IndirectInputOutput'
AtomBios/CD_Operations.c:454: warning: no previous prototype for 'CommonSourceDataTransformation'
AtomBios/CD_Operations.c:461: warning: no previous prototype for 'CommonOperationDataTransformation'
AtomBios/CD_Operations.c:469: warning: no previous prototype for 'ProcessMove'
AtomBios/CD_Operations.c:492: warning: no previous prototype for 'ProcessMask'
AtomBios/CD_Operations.c:507: warning: no previous prototype for 'ProcessAnd'
AtomBios/CD_Operations.c:518: warning: no previous prototype for 'ProcessOr'
AtomBios/CD_Operations.c:527: warning: no previous prototype for 'ProcessXor'
AtomBios/CD_Operations.c:536: warning: no previous prototype for 'ProcessShl'
AtomBios/CD_Operations.c:545: warning: no previous prototype for 'ProcessShr'
AtomBios/CD_Operations.c:555: warning: no previous prototype for 'ProcessADD'
AtomBios/CD_Operations.c:564: warning: no previous prototype for 'ProcessSUB'
AtomBios/CD_Operations.c:573: warning: no previous prototype for 'ProcessMUL'
AtomBios/CD_Operations.c:581: warning: no previous prototype for 'ProcessDIV'
AtomBios/CD_Operations.c:594: warning: no previous prototype for 'ProcessCompare'
AtomBios/CD_Operations.c:610: warning: no previous prototype for 'ProcessClear'
AtomBios/CD_Operations.c:618: warning: no previous prototype for 'ProcessShift'
AtomBios/CD_Operations.c:641: warning: no previous prototype for 'ProcessTest'
AtomBios/CD_Operations.c:651: warning: no previous prototype for 'ProcessSetFB_Base'
AtomBios/CD_Operations.c:658: warning: no previous prototype for 'ProcessSwitch'
AtomBios/CD_Operations.c:681: warning: no previous prototype for 'cmdSetDataBlock'
AtomBios/CD_Operations.c:700: warning: no previous prototype for 'cmdSet_ATI_Port'
AtomBios/CD_Operations.c:707: warning: no previous prototype for 'cmdSet_Reg_Block'
AtomBios/CD_Operations.c:714: warning: no previous prototype for 'cmdSet_X_Port'
AtomBios/CD_Operations.c:720: warning: no previous prototype for 'cmdDelay_Millisec'
AtomBios/CD_Operations.c:726: warning: no previous prototype for 'cmdDelay_Microsec'
AtomBios/CD_Operations.c:734: warning: no previous prototype for 'ProcessPostChar'
AtomBios/CD_Operations.c:742: warning: no previous prototype for 'ProcessDebug'
AtomBios/CD_Operations.c:751: warning: no previous prototype for 'ProcessDS'
AtomBios/CD_Operations.c:756: warning: no previous prototype for 'cmdCall_Table'
AtomBios/CD_Operations.c:774: warning: no previous prototype for 'cmdNOP_'
AtomBios/CD_Operations.c:785: warning: no previous prototype for 'ProcessJump'
AtomBios/CD_Operations.c:798: warning: no previous prototype for 'ProcessJumpE'
AtomBios/CD_Operations.c:811: warning: no previous prototype for 'ProcessJumpNE'
./AtomBios/includes/CD_Common_Types.h:76: warning: ignoring #pragma warning 
./AtomBios/includes/CD_Common_Types.h:150: warning: ignoring #pragma warning 
AtomBios/Decoder.c:54: warning: no previous prototype for 'ProcessCommandProperties'
AtomBios/Decoder.c:89: warning: no previous prototype for 'GetDataMasterTablePointer'
AtomBios/Decoder.c:104: warning: no previous prototype for 'GetTrueIndexInMasterTable'
./AtomBios/includes/CD_Common_Types.h:76: warning: ignoring #pragma warning 
./AtomBios/includes/CD_Common_Types.h:150: warning: ignoring #pragma warning 
AtomBios/hwserv_drv.c:266: warning: no previous prototype for 'ReadRegIO'
AtomBios/hwserv_drv.c:271: warning: no previous prototype for 'WriteRegIO'
AtomBios/hwserv_drv.c:292: warning: no previous prototype for 'AllocateMemory'
AtomBios/hwserv_drv.c:301: warning: no previous prototype for 'ReleaseMemory'
radeon_atombios.c:281: warning: no previous prototype for 'rhdAtomGetTableRevisionAndSize'
radeon_atombios.c:522: warning: no previous prototype for 'rhdAtomSetScaler'
radeon_atombios.c:2005: warning: no previous prototype for 'CailAllocateMemory'
radeon_atombios.c:2013: warning: no previous prototype for 'CailReleaseMemory'
radeon_atombios.c:2021: warning: no previous prototype for 'CailDelayMicroSeconds'
radeon_atombios.c:2031: warning: no previous prototype for 'CailReadATIRegister'
radeon_atombios.c:2045: warning: no previous prototype for 'CailWriteATIRegister'
radeon_atombios.c:2057: warning: no previous prototype for 'CailReadFBData'
radeon_atombios.c:2081: warning: no previous prototype for 'CailWriteFBData'
radeon_atombios.c:2098: warning: no previous prototype for 'CailReadMC'
radeon_atombios.c:2111: warning: no previous prototype for 'CailWriteMC'
radeon_atombios.c:2123: warning: no previous prototype for 'CailReadPCIConfigData'
radeon_atombios.c:2130: warning: no previous prototype for 'CailWritePCIConfigData'
radeon_atombios.c:2192: warning: no previous prototype for 'CailReadPLL'
radeon_atombios.c:2205: warning: no previous prototype for 'CailWritePLL'
radeon_dri.c:473: warning: pointer of type 'void *' used in arithmetic
radeon_dri.c:1447: warning: pointer of type 'void *' used in arithmetic
radeon_exa_funcs.c:244: warning: pointer of type 'void *' used in arithmetic
radeon_exa_funcs.c:360: warning: pointer of type 'void *' used in arithmetic
radeon_exa_funcs.c:244: warning: pointer of type 'void *' used in arithmetic
radeon_exa_funcs.c:360: warning: pointer of type 'void *' used in arithmetic
radeon_exa.c:398: warning: pointer of type 'void *' used in arithmetic
atombios_output.c:741: warning: no previous prototype for 'atombios_output_dpms'
atombios_output.c:902: warning: no previous prototype for 'atombios_output_mode_set'
atombios_output.c:1029: warning: no previous prototype for 'atombios_dac_detect'
atombios_crtc.c:123: warning: no previous prototype for 'atombios_crtc_dpms'
atombios_crtc.c:165: warning: no previous prototype for 'atombios_crtc_set_pll'
atombios_crtc.c:326: warning: no previous prototype for 'atombios_crtc_mode_set'