Bug 14842

Summary:

xorg/driver/xf86-video-xgixp - Patch for missing symbol XGIAdjustFrame

Product:

xorg

Reporter:

Paulo César Pereira de Andrade <pcpa>

Component:

Driver/XGI

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Keywords:

patch

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
0001-Janitor-work-fixing-compile-warnings.patch	none
0001-Janitor-work-fixing-compile-warnings.patch	none
0001-Call-pScrn-AdjustFrame-if-not-NULL.patch	none

Description Paulo César Pereira de Andrade 2008-03-05 13:52:45 UTC

Created attachment 14869 [details] [review]
0001-Janitor-work-fixing-compile-warnings.patch

Major problem was when including the proper header,
XGIPcieMemFree did not compile anymore as the prototype
had one extra parameter.

  This is just a "cosmetic" patch, that probably should be
analyzed, and considered by the official maintainer, if any.
It does not resolve the problem of the missing symbol
drmFenceDestroy, so this driver probably also needs a special
drm branch (or merge of a branch where it is defined) to be
functional.

Comment 1 Paulo César Pereira de Andrade 2008-04-12 16:55:56 UTC

Created attachment 15855 [details] [review]
0001-Janitor-work-fixing-compile-warnings.patch

  Patch remade. Also while remaking patch, removed
lines ending with spaces to avoid git-am/git-apply
warnings, and changed tabs added in new lines to
spaces, to match most of the driver code.

  Note that there is now the missing symbol
XGIAdjustFrame, called by xgi_dga.c and declared
in xgi_driver.h.

Comment 2 Paulo César Pereira de Andrade 2008-07-18 13:35:44 UTC

  Code has changed signficantly since previous patches,
so this patch only prevents a possible fatal error, if
dga is enabled as missing function may be called.

Comment 3 Paulo César Pereira de Andrade 2008-07-18 13:36:50 UTC

Created attachment 17760 [details] [review]
0001-Call-pScrn-AdjustFrame-if-not-NULL.patch

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.