Bug 14764

Summary:

xorg/lib/libXfont - ansification, removal of xf86_ansic.h and rework on stdio wrapper

Product:

xorg

Reporter:

Paulo César Pereira de Andrade <pcpa>

Component:

Lib/Xfont

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Keywords:

patch

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
0001-libXfont-ansification-and-removal-of-xf86_ansic.h-de.patch	none
0002-Disable-some-fun-stdio-wrapping.patch	none
0003-Include-ctype.h-for-isspace.patch	none
0001-libXfont-ansification-and-removal-of-xf86_ansic.h-de.patch	none

Description Paulo César Pereira de Andrade 2008-03-01 11:52:30 UTC

Created attachment 14739 [details] [review]
0001-libXfont-ansification-and-removal-of-xf86_ansic.h-de.patch

"""
libXfont ansification and removal of xf86_ansic.h dependency

  Basically the code is now compiled as if FONTMODULE was never defined,
but also removed some "magic" defining _XOPEN_SOURCE before including
math.h.
  Also removed some #if 0'ed code instead of fixing prototypes inside
the "dead code".
  Changes to spdo_prv.h were due to defines like:
  <hash>define foo() sp_foo()
  that would not compile with the ansification in the format:
  type foo(void)
  due to the macro receiving "void" as an argument.
"""

Comment 1 Paulo César Pereira de Andrade 2008-03-01 11:53:16 UTC

Created attachment 14741 [details] [review]
0002-Disable-some-fun-stdio-wrapping.patch

"""
Disable some fun stdio wrapping.

  The code is still there but no magic with macros is attempted anymore
to handle files.
  This should really be changed to just use stdio, and properly adapt
 functions like T1Decript, T1eexec, etc.
"""

Comment 2 Paulo César Pereira de Andrade 2008-03-01 11:53:34 UTC

Created attachment 14742 [details] [review]
0003-Include-ctype.h-for-isspace.patch

Comment 3 Paulo César Pereira de Andrade 2008-03-13 21:33:46 UTC

Comment on attachment 14742 [details] [review]
0003-Include-ctype.h-for-isspace.patch

This was fixed in commit 754cabe62e91b9ad50c3027c063f4269775f7add

In a different way, as it was added without the ansification patch and other compile warning fixes.

Comment 4 Paulo César Pereira de Andrade 2008-03-13 21:36:55 UTC

Created attachment 15108 [details] [review]
0001-libXfont-ansification-and-removal-of-xf86_ansic.h-de.patch

  Remade patch to also cover other non ansified functions, and
to remove changes that would keep lines with ending spaces (that
cause an warning message from git-am).

  Patch 2 still applies cleanly using git-am.

Comment 5 Alan Coopersmith 2008-12-19 17:04:43 UTC

I released libXfont 1.3.4 to have a stable release to go along with
Xserver 1.6, and then pushed patches #2 & #4 to git so they can start
getting tested for the next release.   (I deleted a couple changes from
#4 - the fontcache files are no longer in the tree, and I'd already fixed
one of the missing void arguments before I saw it was in this patch.)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.