Bug 14683

Summary:

libICE ansification and compile warning fixes

Product:

xorg

Reporter:

Paulo César Pereira de Andrade <pcpa>

Component:

Lib/ICE

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Keywords:

patch

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
0001-libICE-ansification.patch	none
0002-Allow-globals.h-to-be-included-by-other-files.patch	none
0003-Fix-warnings-due-to-using-DICE_t-and-also-defining.patch	none
0004-Move-extern-declarations-to-globals.h.patch	none

Description Paulo César Pereira de Andrade 2008-02-26 09:02:47 UTC

Created attachment 14582 [details] [review]
0001-libICE-ansification.patch

There are no prototypes with char or short arguments,
and the long arguments should are only internal to the
library.

  Also moved externs from C files to headers.

Comment 1 Paulo César Pereira de Andrade 2008-02-26 09:03:24 UTC

Created attachment 14583 [details] [review]
0002-Allow-globals.h-to-be-included-by-other-files.patch

Comment 2 Paulo César Pereira de Andrade 2008-02-26 09:03:49 UTC

Created attachment 14584 [details] [review]
0003-Fix-warnings-due-to-using-DICE_t-and-also-defining.patch

Comment 3 Paulo César Pereira de Andrade 2008-02-26 09:04:09 UTC

Created attachment 14585 [details] [review]
0004-Move-extern-declarations-to-globals.h.patch

Comment 4 Paulo César Pereira de Andrade 2008-02-26 09:04:53 UTC

Comment on attachment 14585 [details] [review]
0004-Move-extern-declarations-to-globals.h.patch

Ops, explicitly mark as patch file.

Comment 5 Paulo César Pereira de Andrade 2009-01-08 14:32:06 UTC

This was corrected in libICE 1.0.5.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.