Bug 14437

Created attachment 14229 [details]
xorg.0.log

Could you help to git bisect which commit could cause the problem you see?

bugzilla-daemon@freedesktop.org wrote:
> 
> --- Comment #2 from Wang Zhenyu <zhenyu.z.wang@intel.com>  2008-02-11 07:01:18 PST ---
> Could you help to git bisect which commit could cause the problem you see?
> 
> 
Sure I want to help but I don't understand "bisect", how to "git bisect"?
I am a physicist, not a programmer!

Jos v.W.

bugzilla-daemon@freedesktop.org wrote:
> --- Comment #2 from Wang Zhenyu <zhenyu.z.wang@intel.com>  2008-02-11 07:01:18 PST ---
> Could you help to git bisect which commit could cause the problem you see?
> 
I got git-clone git://anongit.freedesktop.org/git/xorg/driver/xf86-video-intel
but that's the version that gives some flickering.
Please tell me which versions to git bisect and how to proceed, I never have used git bisect!

祝你新年快乐！
Jos v.W.

(In reply to comment #4)
> 祝你新年快乐！

Thank you! You too! ;)

Here's the doc for git-bisect:
http://www.kernel.org/pub/software/scm/git/docs/git-bisect.html

If you failed to successfully bisect it, I'll try to reproduce it on the 855gm
in my office later.

bugzilla-daemon@freedesktop.org wrote:
> http://bugs.freedesktop.org/show_bug.cgi?id=14437
> If you failed to successfully bisect it, I'll try to reproduce it on the 855gm
> in my office later.
> 
> 

Here is the result of bisect:
---
jos@jewel:~/xf86-video-intel$ git bisect start -- arch/i386
jos@jewel:~/xf86-video-intel$ git bisect bad xf86-video-intel-2.2.0.90
jos@jewel:~/xf86-video-intel$ git bisect good xf86-video-intel-2.2.0
Bisecting: -1 revisions left to test after this
[4a2b0f340357c4ca58dc9586fad1337b83966362] Fix typo in 1920x1080 resolution entry
---
The green flickering appears especially in the right part of the screen when viewing pictures.
It is reproducible whenever I install v. 2.2.0.90 and doesn't occur with v.2.2.0

(In reply to comment #6)

> jos@jewel:~/xf86-video-intel$ git bisect start -- arch/i386

oh, that git-bisect manual page's example is for linux kernel, as arch/i386
(which is gone) used for. For intel video driver, no dir should be needed.

> jos@jewel:~/xf86-video-intel$ git bisect bad xf86-video-intel-2.2.0.90
> jos@jewel:~/xf86-video-intel$ git bisect good xf86-video-intel-2.2.0
> Bisecting: -1 revisions left to test after this
> [4a2b0f340357c4ca58dc9586fad1337b83966362] Fix typo in 1920x1080 resolution
> entry

This commit seems just following 2.2.0 version dump, and shouldn't affect your problem...

bugzilla-daemon@freedesktop.org wrote:
> http://bugs.freedesktop.org/show_bug.cgi?id=14437
> --- Comment #7 from Wang Zhenyu <zhenyu.z.wang@intel.com>  2008-02-17 06:41:48 PST ---
> (In reply to comment #6)
> 

I have found that the flickering originates from xf86-video-intel-2.2.0.90/src/i830_display.c.
When replacing (around line 1727)
	    if ((INREG(LVDS) & LVDS_CLKB_POWER_MASK) == LVDS_CLKB_POWER_UP)
		clock.p2 = I8XX_P2_LVDS_SLOW;
	    else
		clock.p2 = I8XX_P2_LVDS_FAST;
by
	    clock.p2 = 14;
as in the previous version 2.2.0, the flickering no longer occurs.
There must be a reason why this was changed, but it obviously causes a regression!

oh, thanks. Add Hong to cc.

oops, my change to Hong's patch got reverse effect...fix patch is pushed to master.

bugzilla-daemon@freedesktop.org wrote:
> http://bugs.freedesktop.org/show_bug.cgi?id=14437
> 
> 
> 
> 
> 
> --- Comment #10 from Wang Zhenyu <zhenyu.z.wang@intel.com>  2008-02-18 16:55:10 PST ---
> oops, my change to Hong's patch got reverse effect...fix patch is pushed to
> master.
> 
> 
I got your last commit, no more flickering! :)