| Summary: | AlwaysCore/SendCoreEvents broken | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Jan Kandziora <jjj> |
| Component: | Server/General | Assignee: | Xorg Project Team <xorg-team> |
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | major | ||
| Priority: | medium | CC: | jjj |
| Version: | git | Keywords: | janitor, regression |
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=blob;h=cd0c30ac167f5dc9fcf8568df59f72ce3e1a3ed4;hb=e915a2639752bc0ea9e6e192e020cc2031c08063;f=hw/xfree86/common/xf86Xinput.c | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Thanks, pushed as 5b8641a5fdc112c19e78ca2954878712e328d403 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Somewhere between 7.0 and the current state, the handling of the "AlwaysCore", "SendCoreEvents", "CoreKeyboard", and "CorePointer" config options in xorg.conf was broken. See xorg-server-1.4/hw/xfree86/common/xf86Xinput.c 115 xf86ProcessCommonOptions(LocalDevicePtr local, 116 pointer list) 117 { 118 if (xf86SetBoolOption(list, "AlwaysCore", 0) || 119 !xf86SetBoolOption(list, "SendCoreEvents", 1) || 120 !xf86SetBoolOption(list, "CorePointer", 1) || 121 !xf86SetBoolOption(list, "CoreKeyboard", 1)) { 122 xf86Msg(X_CONFIG, "%s: doesn't report core events\n", local->name); 123 } else { 124 local->flags |= XI86_ALWAYS_CORE; 125 xf86Msg(X_CONFIG, "%s: always reports core events\n", local->name); 126 } 127 ... If one uses the "AlwaysCore" option in an "Section InputDevice", the comparison above evaluates to *true* and such, XI86_ALWAYS_CORE is *not* set! In 7.0, this option handling was correct.