Bug 14032

Summary:	i810 should default to 16 bpp
Product:	xorg	Reporter:	Julien Cristau <jcristau>
Component:	Driver/intel	Assignee:	Wang Zhenyu <zhenyu.z.wang>
Status:	RESOLVED FIXED	QA Contact:	Xorg Project Team <xorg-team>
Severity:	normal
Priority:	medium	CC:	michael.fu, tjaalton
Version:	git	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Julien Cristau 2008-01-11 14:43:52 UTC

X fails to start without an xorg.conf on i810, because the default depth set by the server (32) is not supported by the driver.  I think the driver should default to 16 bits (it supports 24, but when I tested it that didn't seem to work very well, and dri is disabled at 24 bits depth anyway) instead of letting the server use 32 and failing later on.

diff --git a/src/i810_driver.c b/src/i810_driver.c
index 1ecb04a..53121a6 100644
--- a/src/i810_driver.c
+++ b/src/i810_driver.c
@@ -954,7 +954,7 @@ I810PreInit(ScrnInfoPtr pScrn, int flags)
    pScrn->monitor = pScrn->confScreen->monitor;
 
    flags24 = Support24bppFb | PreferConvert32to24 | SupportConvert32to24;
-   if (!xf86SetDepthBpp(pScrn, 0, 0, 0, flags24)) {
+   if (!xf86SetDepthBpp(pScrn, 16, 0, 16, flags24)) {
       return FALSE;
    } else {
       switch (pScrn->depth) {

Comment 1 Michael Fu 2008-01-15 17:31:13 UTC

assign to zhenyu for review and check-in. thanks! Julien.

Comment 2 Wang Zhenyu 2008-01-16 22:52:47 UTC

patch pushed, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.