Bug 13134

Summary: Some panoramiX requests fail from a byte swapped client
Product: xorg Reporter: Peter Harris <pharris>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium Keywords: patch
Version: git   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Peter Harris 2007-11-07 11:32:36 UTC 
panoramiXSwap.c is missing a few swapl() calls.

diff --git a/Xext/panoramiXSwap.c b/Xext/panoramiXSwap.c
index da445ff..0487471 100644
--- a/Xext/panoramiXSwap.c
+++ b/Xext/panoramiXSwap.c
@@ -70,6 +70,7 @@ SProcPanoramiXGetState(ClientPtr client)

        swaps (&stuff->length, n);
        REQUEST_SIZE_MATCH(xPanoramiXGetStateReq);
+       swapl (&stuff->window, n);
        return ProcPanoramiXGetState(client);
 }

@@ -81,6 +82,7 @@ SProcPanoramiXGetScreenCount(ClientPtr client)

        swaps (&stuff->length, n);
        REQUEST_SIZE_MATCH(xPanoramiXGetScreenCountReq);
+       swapl (&stuff->window, n);
        return ProcPanoramiXGetScreenCount(client);
 }

@@ -92,6 +94,8 @@ SProcPanoramiXGetScreenSize(ClientPtr client)

        swaps (&stuff->length, n);
        REQUEST_SIZE_MATCH(xPanoramiXGetScreenSizeReq);
+       swapl (&stuff->window, n);
+       swapl (&stuff->screen, n);
        return ProcPanoramiXGetScreenSize(client);
 }

--
1.5.3.5
Comment 1 Alan Coopersmith 2008-01-29 09:42:25 UTC 
Patch has already been applied to git head, so marking as fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.