Bug 12790 (xkbprint)

Summary:

xkbprint produce wrong internal outline with cornerRadius

Product:

xorg

Reporter:

Pavel Kurashov <pavell>

Component:

App/other

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

minor

Priority:

low

Keywords:

patch

Version:

unspecified

Hardware:

All

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
xkbprint psgeom.c Diff	none
xkbprint One key keyboard image without patch	none
xkbprint One key keyboard with patch, no more tail	none
reformulation of psgeom.c Diff	none

Description Pavel Kurashov 2007-10-12 06:10:36 UTC

When generating image of a keyboard geometry with xkbprint, it does not care about cornerRadius for outlines defined by two pair coordinates. As a result, on the keyboard produced image you can notice small tail in the left-upper corner of internal outline of a key (which usualy defined by two pair coordinates). This tail because of cornerRadius not taken into account for the starting drawing point.
Difference in old and fixed with patch xkbprint pictures can be seen in pdfs attached.

Comment 1 Pavel Kurashov 2007-10-12 06:12:58 UTC

Created attachment 12008 [details] [review]
xkbprint psgeom.c Diff

Comment 2 Pavel Kurashov 2007-10-12 06:16:23 UTC

Created attachment 12009 [details]
xkbprint One key keyboard image without patch

This is how key looks with small tail, produced by xkbprint with patch

Comment 3 Pavel Kurashov 2007-10-12 06:19:04 UTC

Created attachment 12010 [details]
xkbprint One key keyboard with patch, no more tail

When the cornerRadius is used, outline is looking fine

Comment 4 Peter Breitenlohner 2008-11-14 05:06:04 UTC

Created attachment 20303 [details] [review]
reformulation of psgeom.c Diff

This is a real bug, patch should be applied (I just reformulated it against current git) in addition to those for bug #15207

Comment 5 Peter Breitenlohner 2008-11-14 05:14:35 UTC

(In reply to comment #4)
> Created an attachment (id=20303) [details]
> reformulation of psgeom.c Diff
> 
> This is a real bug, patch should be applied (I just reformulated it against
> current git) in addition to those for bug #15207
> 

Sorry, that should have been: in addition to those for bug #15078

Comment 6 Paulo César Pereira de Andrade 2008-11-27 22:13:29 UTC

Thanks.

Applied as 885f2712b0d5137d5349c3debbcea0db0f39e92f

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.