Bug 12675

Summary:	[patch] replace invalid assert in dbus_g_proxy_begin_call_internal
Product:	dbus	Reporter:	Kimmo Hämäläinen <kimmo.hamalainen>
Component:	GLib	Assignee:	Rob Taylor <rob.taylor>
Status:	RESOLVED FIXED	QA Contact:	John (J5) Palmieri <johnp>
Severity:	normal
Priority:	medium	CC:	walters
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	proposed patch new, tested patch

Description Kimmo Hämäläinen 2007-10-04 05:33:57 UTC

We've had several core dumps for this g_assert(), and I found out why it triggers:  pending == NULL can be returned when the connection has been disconnected (it's in the API documentation). I'll attach a patch.

Comment 1 Kimmo Hämäläinen 2007-10-04 05:34:55 UTC

Created attachment 11898 [details] [review]
proposed patch

Comment 2 Kimmo Hämäläinen 2007-10-19 04:28:56 UTC

The patch needs a small fix: use g_debug() instead of g_error()...

Comment 3 Kimmo Hämäläinen 2007-10-19 07:15:14 UTC

Created attachment 12122 [details] [review]
new, tested patch

Comment 4 Colin Walters 2008-05-27 11:21:09 UTC

I tweaked this patch slightly by removing the g_debug (we don't have any other ones in the code) and adding a comment linking back to this bug.

Thanks for all the patches by the way, and sorry about taking so long to add them!

commit ad35bf13f93d18b0b0e8f930ff79af9dcc1c8508
Author: Colin Walters <walters@verbum.org>
Date:   Tue May 27 14:18:49 2008 -0400

    Bug 12675: Handle disconnected connections in calls (Kimmo Hämäläinen)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.