Bug 1257

Summary: [regression] slash key broken on br abnt2 keyboards
Product: xorg Reporter: Alexandre Oliva <aoliva>
Component: App/xkbcompAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: ago, mharris
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
URL: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=130789
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 1690    
Attachments:
Description Flags
revert change none

Description Alexandre Oliva 2004-08-31 10:23:39 UTC
xorg-x11-6.7.99.903-1 (as built by Mike Harris for Fedora Core development) has
a major regression in the br-abnt2 keyboard description.  The key used to input
slash and question mark has no effect.  According to Red Hat bugzilla 130789,
removing the `<AB11> = 123;' line from the abnt2 definition in
xkb/keycodes/xfree86, the problem goes away.  I can't quite figure out why this
line is there.  It wasn't in the previous release of xorg-x11.  Could it please
be taken out?  Thanks,
Comment 1 Alexandre Oliva 2004-08-31 10:25:07 UTC
Marking as a blocker for 6.8.0, as suggested by Mike Harris.
Comment 2 Alexander Gottwald 2004-08-31 13:54:19 UTC
was introduced with #533

We had reports with Cygwin/X that this key does not work. 
Which keycode is associated to that key?

http://sources.redhat.com/ml/cygwin-xfree/2004-04/msg00345.html
Comment 3 Alexandre Oliva 2004-08-31 18:03:19 UTC
I'll try to find that out, but 123 is assigned to both AB11 (in abnt2) and to
KPDC (inherited from xfree86(basic)).  This can't be right, can it?
Comment 4 Ulisses Furquim 2004-08-31 19:10:42 UTC
My abnt2 keyboard works fine with Fedora's xorg-x11-6.7.0-5. The abnt2
description in xkb/keycodes/xfree86 doesn't define a keycode value for <AB11>,
but basic defines it as 211.
Comment 5 Alexandre Oliva 2004-08-31 19:53:04 UTC
I'd asked Ulisses to look for a key with code 123, and he couldn't find any such
key.  He confirms FC2's xorg-x11 works perfectly with an ABNT2 keyboard.  Clovis
(from the Red Hat bugzilla bug report) confirms xorg-x11 in rawhide (pre-6.8.0)
fails, and that reverting the change gets the keyboard back to a functional state.
Comment 6 Alexander Gottwald 2004-09-01 04:29:01 UTC
Windows reports keycode 123 for that key. Old XFree reported it too. I found
references all over the net which use 123 for this key.
http://www.inf.ufsc.br/~emilio/teclado/abnt2.pke

Why was it changed?

The same problem is pending for two keys on the jp106 keyboard
Comment 7 Alexander Gottwald 2004-09-01 05:28:01 UTC
Created attachment 803 [details] [review]
revert change
Comment 8 Kevin E. Martin 2004-09-01 12:07:56 UTC
We talked about this bug on the call today, and thought that the fix looked okay
for this release.  We should look at fixing up other keycode related issues
after this release.

Patch is checked in.  Moving to bug 999 for documentation in the release notes.
Comment 9 Mike A. Harris 2004-09-01 12:35:40 UTC
Closing bug as "FIXED" from Kevin's comment above.
Comment 10 Alexander Gottwald 2004-09-02 02:18:45 UTC
Keep the bug open. It must be investigated after the release.

I'll ship the cygwin build with <AB11> = 123 to avoid a regression on cygwin but
this must be solved after the release.
Comment 11 Alexander Gottwald 2005-01-10 09:27:08 UTC
I've adjusted the keycodes for the two keys in XWin. This should fix the problem
for cygwin and will not affect other systems again.

marking as FIXED

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.