Bug 12482

Summary: segfault on Xorg startup at miSpriteInitialize
Product: xorg Reporter: Sami Farin <safari-ml-freedesktop-bugzilla-kv7oy2vp4mc4jvudr6vccb7oetrzzqe7fwnhahno>
Component: * OtherAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED INVALID QA Contact: Xorg Project Team <xorg-team>
Severity: critical    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
xorg log / crash in miSpriteInitialize none

Description Sami Farin 2007-09-18 17:12:44 UTC
xorg-server-1.3.99.0-269-g547ad21 / x86_64
xf86-video-intel-2.1.0-88-gbda3c69

the same software version works in 32bit mode.

when I hacked around and did this, 64bit Xorg starts up:

index 0b402fa..f15f233 100644
--- a/mi/misprite.c
+++ b/mi/misprite.c
@@ -181,7 +181,7 @@ miSpriteInitialize (pScreen, cursorFuncs, screenFuncs)
        return FALSE;
     }
     for (pVisual = pScreen->visuals;
-        pVisual->vid != pScreen->rootVisual;
+        pVisual && pVisual->vid && pVisual->vid != pScreen->rootVisual;
         pVisual++)
        ;
     pScreenPriv->pVisual = pVisual;
Comment 1 Sami Farin 2007-09-18 17:13:39 UTC
Created attachment 11628 [details]
xorg log / crash in miSpriteInitialize
Comment 2 Adam Jackson 2008-02-29 13:51:03 UTC
No, I don't believe this.  If your screen has no visuals, something else is seriously wrong.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.