Bug 12166

Summary: Make ACPI handling less mad
Product: xorg Reporter: Matthew Garrett <mjg59>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Proposed patch none

Description Matthew Garrett 2007-08-26 08:43:55 UTC 
The server sends configuration change events whenever any form of ACPI hotkey event comes in. This includes brightness keys. There's no mechanism provided to distinguish between the potential sources of the event, which leads to issues like -i810 performing a screen toggle when a user changes the brightness. In the absence of any sensible way of telling the difference, we should just skip sending these events for brightness keys.
Comment 1 Matthew Garrett 2007-08-26 08:44:27 UTC 
Created attachment 11278 [details] [review]
Proposed patch

Don't send events if it's not a display toggle button press
Comment 2 Adam Jackson 2010-08-09 13:01:33 UTC 
commit 74e84b8d891632141a60e2d29463ab46f622df3f
Author: Matthias Hopf <mhopf@suse.de>
Date:   Fri Oct 19 17:28:15 2007 +0200

    Only issue XF86_APM_CAPABILITY_CHANGED for video change ACPI events (not e.g brightness etc.).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.