Bug 11715

Summary: broken Xserver version detection
Product: xorg Reporter: Julien Cristau <jcristau>
Component: Driver/SiSAssignee: Thomas Winischhofer <thomas>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 8888    
Attachments:
Description Flags
proposed patch
none
don't depend on XFree86Server being set none

Description Julien Cristau 2007-07-24 13:25:31 UTC 
With xserver 1.3, XORG_VERSION_CURRENT changed from 7.x to 1.x, which broke
some detection code in the sis driver (it checks for some drm interface
changes using #if XORG_VERSION_CURRENT >= XORG_VERSION_NUMERIC(6,8,99,900,0)).

The attached patch seems to fix this.
Comment 1 Julien Cristau 2007-07-24 13:26:49 UTC 
Created attachment 10873 [details] [review]
proposed patch
Comment 2 Julien Cristau 2007-08-01 11:25:16 UTC 
Created attachment 10941 [details] [review]
don't depend on XFree86Server being set

Recent versions of xserver don't define XFree86Server, so this patch is also needed.
Comment 3 Julien Cristau 2007-08-20 19:54:50 UTC 
Fixed:

commit ba3c4d45d6e8f04536e6512103db820f0d21b77a
Author: Julien Cristau <jcristau@debian.org>
Date:   Thu Aug 9 03:36:07 2007 +0200

    Get rid of the XFree86Server macro.
    
    It's not exported by xserver these days, so don't test it.

commit 391dad44fa305be4cded31cf2f9a4fba7420af99
Author: Julien Cristau <jcristau@debian.org>
Date:   Thu Aug 9 03:35:12 2007 +0200

    Fix xserver version detection.
    
    Newer xserver releases report a version of 1.x, which is smaller
    than 6.8.99.900.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.