Bug 111579

Summary:	[regression][bisected] Piglit spec.arb_cull_distance.clip-cull-* test assertion
Product:	Mesa	Reporter:	Clayton Craft <clayton.a.craft>
Component:	Drivers/Gallium/Iris	Assignee:	Rhys Perry <pendingchaos02+fdobugzilla>
Status:	RESOLVED FIXED	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	not set
Priority:	not set	Keywords:	bisected, regression
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Clayton Craft 2019-09-06 20:15:56 UTC

The following tests fail with an assertion on all i965 and Iris platforms:
spec.arb_cull_distance.clip-cull-1
spec.arb_cull_distance.clip-cull-2
spec.arb_cull_distance.clip-cull-3
spec.arb_cull_distance.clip-cull-4

Output:
shader_runner: ../src/compiler/nir/nir_validate.c:1076: validate_var_decl: Assertion `glsl_type_is_scalar(type)' failed.


Bisected to:

commit 300e758b7c428289909b318bb0df230b22ab5d9b
Author: Rhys Perry <pendingchaos02@gmail.com>
Date:   Fri May 17 11:53:32 2019 +0100

    nir/lower_io_to_vector: allow FS outputs to be vectorized

    v2: handle dual-source blending
    v3: use a higher MAX_SLOTS

    Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
    Reviewed-by: Connor Abbott <cwabbott0@gmail.com>

Comment 1 Kenneth Graunke 2019-09-06 22:40:00 UTC

Fixed by:

commit 6b8cb087568699ca9a6e9e8b7bf49179e622b59f
Author: Rhys Perry <pendingchaos02@gmail.com>
Date:   Fri Sep 6 21:38:57 2019 +0100

    nir/lower_io_to_vector: don't merge compact varyings
    
    Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
    Fixes: 02bc4aabb48 ('nir/lower_io_to_vector: allow FS outputs to be vectorized')
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.