Bug 111263

Summary: [g965] gpu hang on uniform-update.shader_test
Product: Mesa Reporter: Mark Janes <mark.a.janes>
Component: Drivers/DRI/i965Assignee: Jason Ekstrand <jason>
Status: RESOLVED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium Keywords: bisected, regression
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: card0 error state

Description Mark Janes 2019-07-30 22:51:52 UTC 
Created attachment 144915 [details]
card0 error state

Bisected to:

4bb6e6817ec5d627d58e499ca09f1f40641a1acd
Author:     Jason Ekstrand <jason@jlekstrand.net>
intel: Use a system value for gl_FragCoord

It's kind-of an anomaly that the Intel drivers are still treating
gl_FragCoord as an input.  It also makes zero sense because we have to
special-case it in the back-end.

Because ANV is the only user of nir_lower_wpos_center, we go ahead and
just update it to look for nir_intrinsic_load_frag_coord as part of this
patch.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>


On g965, you can reproduce with:

PIGLIT_PLATFORM=gbm /tmp/build_root/m64/lib/piglit/bin/shader_runner /tmp/build_root/m64/lib/piglit/tests/spec/glsl-1.10/execution/uniform-update.shader_test -auto -fbo
Comment 2 Jason Ekstrand 2019-07-31 00:22:12 UTC 
Fixed by the following commit in master:

commit 9265e9d11aa20697d3d9871c2bd0b5402b135dbd
Author: Jason Ekstrand <jason@jlekstrand.net>
Date:   Tue Jul 30 18:07:08 2019 -0500

    i965/curbe: Look at SYSTEM_VALUE_FRAG_COORD instead of VARYING_SLOT_POS
    
    When transitioning gl_FragCoord over to a system value, we missed one
    instance of VARYING_SLOT_POS in i965.  As of this commit, i965 has no
    references to VARYING_SLOT_POS.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111263
    Fixes: 4bb6e6817ec "intel: Use a system value for gl_FragCoord"
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.