Bug 110857

Summary:	[bisected][regression][ILK, G965, G45] dEQP-GLES2.functional.shaders.operator.selection.bvec{2,3,4} failures
Product:	Mesa	Reporter:	Clayton Craft <clayton.a.craft>
Component:	Drivers/DRI/i965	Assignee:	Ian Romanick <idr>
Status:	RESOLVED FIXED	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	normal
Priority:	medium	Keywords:	bisected, regression
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Clayton Craft 2019-06-07 18:20:37 UTC

The following dEQP tests are failing on ILK, G965, and G45 platforms:

dEQP-GLES2.functional.shaders.operator.selection.bvec2_fragment
dEQP-GLES2.functional.shaders.operator.selection.bvec3_fragment
dEQP-GLES2.functional.shaders.operator.selection.bvec4_fragment


Output from dEQP-GLES2.functional.shaders.operator.selection.bvec2_fragment on G965:

> Image comparison failed: difference = 6638.42, threshold = 0.05



Bisected to:

commit 1c30d26d89c52b253062522d4ea488c22a83a7ab
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Tue Jun 4 12:16:55 2019 -0700

    intel/compiler: Treat b32csel as potentially producing a Boolean result for resolve analysis

Comment 1 Ian Romanick 2019-06-10 17:57:35 UTC

MR submitted: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1068

Comment 2 Ian Romanick 2019-06-11 19:47:18 UTC

Fix by:

commit 39f4dc23a5af1b78a58905cf91d56441b59eb80a
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Fri Jun 7 15:45:03 2019 -0700

    intel/fs: Mark source 0 of bcsel as needing Boolean resolve
    
    The other sources of the bcsel behave like the sources of an and or
    other logical operation.  However, source zero behaves differently.
    It is evaluated as a Boolean, so it needs to be resolved.
    
    No shader-db changes, but the tests mentioned in the bug get a couple
    instructions added back.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110857
    Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.