Bug 110832

Summary:	Commit 911ea2c66fc54c5066707f7fe4451ec573792ae7 breaks Elite Dangerous shader compiling
Product:	Mesa	Reporter:	Haxk20 <haxk612>
Component:	glsl-compiler	Assignee:	Jason Ekstrand <jason>
Status:	RESOLVED FIXED	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	normal
Priority:	medium	CC:	caio.oliveira
Version:	git	Keywords:	bisected, regression
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Haxk20 2019-06-03 20:09:40 UTC

I have updated Mesa as i usually do after few days and tried to launch Elite Dangerous as i usually do in free time and noticed that the game crashes at 55% shader compiling every time i launch it.
Downgraded and game was working.
So i started going trough the commits and trying each one of them (Took very long time) and the commit that breaks it is 911ea2c66fc54c5066707f7fe4451ec573792ae7.

If you need logs or anything else im happy to provide all of that.

Thank you.

Comment 1 Mark Janes 2019-06-03 20:46:20 UTC

Thanks for taking the time to isolate this.  Git's bisect functionality might speed this up for you next time:

  https://git-scm.com/docs/git-bisect

Comment 2 Caio Marcelo de Oliveira Filho 2019-06-03 21:28:08 UTC

The output might help, usually has the indication of which part of the code crashed and/or which assertion failed.

I have speculative fix that may or may not help here if you want to try: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/992

Comment 3 Haxk20 2019-06-03 22:07:04 UTC

(In reply to Mark Janes from comment #1)
> Thanks for taking the time to isolate this.  Git's bisect functionality
> might speed this up for you next time:
> 
>   https://git-scm.com/docs/git-bisect

Yes i know about git bisect its just that i didnt have the "best" experience with it over the years of programming. It usually is incorrect on the commit that it says.
But yes in this case it would speed the process up.

Comment 4 Haxk20 2019-06-03 22:07:48 UTC

(In reply to Haxk20 from comment #3)
> (In reply to Mark Janes from comment #1)
> > Thanks for taking the time to isolate this.  Git's bisect functionality
> > might speed this up for you next time:
> > 
> >   https://git-scm.com/docs/git-bisect
> 
> Yes i know about git bisect its just that i didnt have the "best" experience
> with it over the years of programming. It usually is incorrect on the commit
> that it says.
> But yes in this case it would speed the process up.

Indeed your "speculative" fix fixed the issue.
Thank you.

Comment 5 Caio Marcelo de Oliveira Filho 2019-06-04 00:20:27 UTC

Fix landed in master:

commit ea0e89859c9f2e5f0b3055d822663b2ee5904cb3
Author: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Date:   Mon Jun 3 14:13:16 2019 -0700

    nir/vars_to_ssa: Handle UNDEF_NODE in more places
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110832
    Fixes: 911ea2c66fc "nir/vars_to_ssa: Use a non-null UNDEF_NODE pointer"
    Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.