Bug 110474

Summary: [bisected][regression] vk cts fp16 arithmetic failures
Product: Mesa Reporter: Clayton Craft <clayton.a.craft>
Component: Drivers/DRI/i965Assignee: Ian Romanick <idr>
Status: RESOLVED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium Keywords: bisected, regression
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Clayton Craft 2019-04-19 22:46:54 UTC 
The full list of failing tests can be found here, along with their output: http://mesa-ci.01.org/vulkancts/builds/11000/group/63a9f0ea7bb98050796b649e85481845#fails


This has been bisected to the following commit:

commit ad98fbc21743cac60abd40a98f0796a8db4a250d
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Mon Jun 25 19:50:56 2018 -0700

    intel/fs: Refactor code generation for nir_op_fsign to its own function

    v2: Call emit_fsign from inside the existing switch statement.
    Suggested by Matt.

    Reviewed-by: Matt Turner <mattst88@gmail.com>
Comment 1 Ian Romanick 2019-04-20 00:40:20 UTC 
I'm planning to land https://gitlab.freedesktop.org/mesa/mesa/merge_requests/694 in a little bit.
Comment 2 Ian Romanick 2019-04-27 08:46:37 UTC 
Fixed by:

commit a6ccc4c0c893cfd978068f1d75ad0e001182b381
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Thu Apr 18 15:09:06 2019 -0700

    intel/fs: Add support for float16 to the fsign optimizations
    
    Commit ad98fbc2174 ("intel/fs: Refactor code generation for nir_op_fsign
    to its own function") criss-crossed with c2b8fb9a810 ("anv/device:
    expose VK_KHR_shader_float16_int8 in gen8+"), and I was not paying
    enough attention when I rebased.  This adds back the float16 changes and
    enables the optimization.
    
    v2: Incorporate more changes from 19cd2f5debd and a8d8b1a1391 that I
    missed in the previous version.
    
    Fixes: ad98fbc2174 ("intel/fs: Refactor code generation for nir_op_fsign to its own function")
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110474
    Reviewed-by: Matt Turner <mattst88@gmail.com> [v1]

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.