Bug 109944

Summary:	[bisected] Android build test fails with: utils.c: error: use of undeclared identifier 'PACKAGE_VERSION'
Product:	Mesa	Reporter:	Clayton Craft <clayton.a.craft>
Component:	Other	Assignee:	Eric Engestrom <fdo-bugs>
Status:	RESOLVED FIXED	QA Contact:	mesa-dev
Severity:	normal
Priority:	medium	Keywords:	bisected
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Clayton Craft 2019-03-08 20:22:45 UTC

[ 39% 1228/3101] target  C: libmesa_dri_common_32 <= vendor/intel/external/project-celadon/mesa/src/mesa/drivers/dri/common/utils.c
FAILED: out/target/product/cel_apl/obj_x86/STATIC_LIBRARIES/libmesa_dri_common_intermediates/utils.o
/bin/bash -c "PWD=/proc/self/cwd  prebuilts/clang/host/linux-x86/clang-4691093/bin/clang        -I vendor/intel/external/project-celadon/mesa/include -I vendor/intel/external/project-celadon/mesa/src/egl/drivers/dri -I vendor/intel/external/project-celadon/mesa/src/egl/main -I vendor/intel/external/project-celadon/mesa/src/mapi -I vendor/intel/external/project-celadon/mesa/src/mesa -I vendor/intel/external/project-celadon/mesa/src/mesa/drivers/dri/common -I vendor/intel/external/project-celadon/mesa/src/util -I vendor/intel/external/project-celadon/mesa/src/gallium/include -I vendor/intel/external/project-celadon/mesa/src/gallium/auxiliary -I external/expat/lib -I vendor/intel/external/project-celadon/mesa/src -I vendor/intel/external/project-celadon/mesa/include -I vendor/intel/external/project-celadon/mesa/src/mesa/drivers/dri/common -I out/target/product/cel_apl/obj_x86/STATIC_LIBRARIES/libmesa_dri_common_intermediates -I out/target/product/cel_apl/gen/STATIC_LIBRARIES/libmesa_dri_common_intermediates \$(cat out/target/product/cel_apl/obj_x86/STATIC_LIBRARIES/libmesa_dri_common_intermediates/import_includes)   -isystem out/target/product/cel_apl/obj/include -c  -msse3 -mstackrealign -DANDROID -fmessage-length=0 -W -Wall -Wno-unused -Winit-self -Wpointer-arith -no-canonical-prefixes -DNDEBUG -UDEBUG -fno-exceptions -Wno-multichar -O2 -g -fno-strict-aliasing -fdebug-prefix-map=/proc/self/cwd= -D__compiler_offsetof=__builtin_offsetof -Werror=int-conversion -Wno-reserved-id-macro -Wno-format-pedantic -Wno-unused-command-line-argument -fcolor-diagnostics -Wno-expansion-to-defined -Wno-zero-as-null-pointer-constant -fdebug-prefix-map=\$PWD/= -ffunction-sections -fdata-sections -fno-short-enums -funwind-tables -fstack-protector-strong -Wa,--noexecstack -D_FORTIFY_SOURCE=2 -Wstrict-aliasing=2 -Werror=return-type -Werror=non-virtual-dtor -Werror=address -Werror=sequence-point -Werror=date-time -Werror=format-security -nostdlibinc -m32 -march=prescott -target i686-linux-android -Bprebuilts/gcc/linux-x86/x86/x86_64-linux-android-4.9/x86_64-linux-android/bin   -std=gnu99    -Wno-error -Werror=incompatible-pointer-types -DANDROID_API_LEVEL=28 -DENABLE_SHADER_CACHE -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS -DHAVE___BUILTIN_EXPECT -DHAVE___BUILTIN_FFS -DHAVE___BUILTIN_FFSLL -DHAVE_DLFCN_H -DHAVE_FUNC_ATTRIBUTE_FLATTEN -DHAVE_FUNC_ATTRIBUTE_UNUSED -DHAVE_FUNC_ATTRIBUTE_FORMAT -DHAVE_FUNC_ATTRIBUTE_PACKED -DHAVE_FUNC_ATTRIBUTE_ALIAS -DHAVE_FUNC_ATTRIBUTE_NORETURN -DHAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL -DHAVE_FUNC_ATTRIBUTE_WARN_UNUSED_RESULT -DHAVE___BUILTIN_CTZ -DHAVE___BUILTIN_POPCOUNT -DHAVE___BUILTIN_POPCOUNTLL -DHAVE___BUILTIN_CLZ -DHAVE___BUILTIN_CLZLL -DHAVE___BUILTIN_UNREACHABLE -DHAVE_PTHREAD=1 -DHAVE_DLADDR -DHAVE_DL_ITERATE_PHDR -DHAVE_LINUX_FUTEX_H -DHAVE_ENDIAN_H -DHAVE_ZLIB -DMAJOR_IN_SYSMACROS -DVK_USE_PLATFORM_ANDROID_KHR -fvisibility=hidden -fno-math-errno -fno-trapping-math -Wno-sign-compare -Wno-self-assign -Wno-constant-logical-operand -Wno-format -Wno-incompatible-pointer-types -Wno-enum-conversion -DHAVE_LIBDRM -D__ANDROID_API__=28 -D__ANDROID_VNDK__ -fPIC -DDEFAULT_DRIVER_DIR=\\\"/vendor/lib/dri\\\" -D_USING_LIBCXX -DANDROID_STRICT -std=c99  -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -Werror=address-of-temporary -Werror=return-type -Wno-tautological-constant-compare -Wno-null-pointer-arithmetic -Wno-enum-compare -Wno-enum-compare-switch -MD -MF out/target/product/cel_apl/obj_x86/STATIC_LIBRARIES/libmesa_dri_common_intermediates/utils.d -o out/target/product/cel_apl/obj_x86/STATIC_LIBRARIES/libmesa_dri_common_intermediates/utils.o vendor/intel/external/project-celadon/mesa/src/mesa/drivers/dri/common/utils.c"
vendor/intel/external/project-celadon/mesa/src/mesa/drivers/dri/common/utils.c:534:38: error: use of undeclared identifier 'PACKAGE_VERSION'


Bisected to this commit:

commit e1d81decf7a093867f051786a5d7f6ce4d827ff1
Author: Eric Engestrom <eric.engestrom@intel.com>
Date:   Tue Nov 20 12:32:18 2018 +0000

    build: make passing an incorrect pointer type a hard error

    More or less any of this issue pointed out by the compiler is
    a coding error. Make sure we flag it and bail loudly.

    v2: - apply the change to autotools and scons as well (Emil)
        - C++ doesn't need this, it's already an error and the flag
          doesn't exist (Gert)
    v3: - drop scons, flags are not checked so until someone adds that
          functionality we can't have this.

    Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
    Reviewed-by: Dylan Baker <dylan@pnwbakers.com> # v1
    Reviewed-by: Emil Velikov <emil.velikov@collabora.com> # v1
    [Emil: apply the same change to autotools and scons]
    Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
    Reviewed-by: Eric Anholt <eric@anholt.net>

Comment 1 Eric Engestrom 2019-03-08 21:05:17 UTC

Oh FFS, I forgot a backslash at the end of the line I added in Android.common.mk… :facepalm:

Pushing a fix in a minute.

Comment 2 Eric Engestrom 2019-03-08 21:21:15 UTC

commit f67c8701799ec29083f40373f74027f9b1d6dbc6
Author: Eric Engestrom <eric.engestrom@intel.com>
Date:   Fri Mar 8 20:56:38 2019 +0000

    android: fix missing backspace for line continuation

    Reported-by: Clayton Craft <clayton.a.craft@intel.com>
    Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109944
    Fixes: e1d81decf7a093867f05 "build: make passing an incorrect pointer type a hard error"
    Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.