| Summary: | [CI][BAT] boot - aborted - *ERROR* mismatch in pipe_bpp (expected 24, found 0) | ||
|---|---|---|---|
| Product: | DRI | Reporter: | Martin Peres <martin.peres> |
| Component: | DRM/Intel | Assignee: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Severity: | normal | ||
| Priority: | highest | CC: | intel-gfx-bugs, jani.saarinen, jwrdegoede, ville.syrjala |
| Version: | XOrg git | Keywords: | regression |
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | ReadyForDev | ||
| i915 platform: | BXT | i915 features: | display/DSI |
|
Description
Martin Peres
2019-01-31 11:23:09 UTC
The CI Bug Log issue associated to this bug has been updated. ### New filters associated * BXT: igt@runner@aborted - fail - Previous test: nothing - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3677/fi-bxt-j4205/igt@runner@aborted.html - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12001/fi-bxt-j4205/igt@runner@aborted.html - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2326/fi-bxt-dsi/igt@runner@aborted.html - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12104/fi-bxt-dsi/igt@runner@aborted.html - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12105/fi-bxt-dsi/igt@runner@aborted.html - https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4802/fi-bxt-dsi/igt@runner@aborted.html Due to regression, priority is set as Highest. commit ca0b04db14a51893322a2a4638a41dc79c2cf98a Author: Hans de Goede <hdegoede@redhat.com> Date: Sat Dec 1 12:31:45 2018 +0100 drm/i915/dsi: Fix pipe_bpp for handling for 6 bpc pixel-formats stops reading the pipe_bpp from hardware in DSI encoder->get_config hook. This is required for BXT/GLK DSI. (In reply to Jani Nikula from comment #3) > commit ca0b04db14a51893322a2a4638a41dc79c2cf98a > Author: Hans de Goede <hdegoede@redhat.com> > Date: Sat Dec 1 12:31:45 2018 +0100 > > drm/i915/dsi: Fix pipe_bpp for handling for 6 bpc pixel-formats > > stops reading the pipe_bpp from hardware in DSI encoder->get_config hook. > This is required for BXT/GLK DSI. Weird, I would expect pipe_config->pipe_bpp to get set from get_pipe_config in intel_display.c and for 6bpp color formats this should not be overriden with mipi_dsi_pixel_format_to_bpp(fmt) because there the pipe_bpp may be different from dsi bpp (when dsi is using sparse 6bpp, so 6bpp packed in 24 bits per pixel). But I only tested on BYT and CHT hardware, so if this chunk: --- a/drivers/gpu/drm/i915/vlv_dsi.c +++ b/drivers/gpu/drm/i915/vlv_dsi.c @@ -1059,10 +1064,8 @@ static void bxt_dsi_get_pipe_config(struct intel_encoder *encoder, } fmt = I915_READ(MIPI_DSI_FUNC_PRG(port)) & VID_MODE_FORMAT_MASK; - pipe_config->pipe_bpp = - mipi_dsi_pixel_format_to_bpp( - pixel_format_from_register_bits(fmt)); - bpp = pipe_config->pipe_bpp; + bpp = mipi_dsi_pixel_format_to_bpp( + pixel_format_from_register_bits(fmt)); /* Enable Frame time stamo based scanline reporting */ adjusted_mode->private_flags |= Needs to be reverted that is fine with me. I'm afraid I'm totally swamped with other stuff. Jani can you do a patch reverting that chunk and then see of it makes the test-case in question happy again? Fixed with commit 499653501baf27d26e73cb5ce744869df3400509 Author: Ville Syrjälä <ville.syrjala@linux.intel.com> Date: Fri Apr 5 17:13:49 2019 +0300 drm/i915: Fix pipe_bpp readout for BXT/GLK DSI (In reply to Ville Syrjala from comment #5) > Fixed with > > commit 499653501baf27d26e73cb5ce744869df3400509 > Author: Ville Syrjälä <ville.syrjala@linux.intel.com> > Date: Fri Apr 5 17:13:49 2019 +0300 > > drm/i915: Fix pipe_bpp readout for BXT/GLK DSI Thanks, fixed in drmtip_252! The CI Bug Log issue associated to this bug has been archived. New failures matching the above filters will not be associated to this bug anymore. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.