| Summary: | make check test_replace_src_bitsize failure | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Mesa core | Assignee: | Connor Abbott <cwabbott0> |
| Status: | RESOLVED FIXED | QA Contact: | mesa-dev |
| Severity: | normal | ||
| Priority: | medium | CC: | baker.dylan.c, cwabbott0, jason |
| Version: | git | Keywords: | bisected, regression |
| Hardware: | x86-64 (AMD64) | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
commit 2845c492187bbf763e06c5b4325fdac8fdc027c8 Author: Connor Abbott <cwabbott0@gmail.com> Date: Fri Dec 7 10:48:22 2018 +0100 nir: Fixup algebraic test for variable-sized conversions b2i can now take any size boolean in preparation for 1-bit booleans, so the error message printed is slightly different. Fixes: dca6cd9ce65 ("nir: Make boolean conversions sized just like the others") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108961 Cc: Jason Ekstrand <jason@jlekstrand.net> Acked-by: Jason Ekstrand <jason@jlekstrand.net> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
FAIL: test_replace_src_bitsize (__main__.ValidatorTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "./nir/tests/algebraic_parser_test.py", line 70, in test_replace_src_bitsize "Sources a (bit size of a) and b (bit size of 32) " \ File "./nir/tests/algebraic_parser_test.py", line 47, in common self.assertEqual(message, str(context.exception)) AssertionError: "Sources a (bit size of a) and b (bit size of 32) of ('iadd', 'a', 'b') may not have the same bit size when building the replacement expression." != "Sources a (bit size of a) and b (bit size of b) of ('iadd', 'a', 'b') may not have the same bit size when building the replacement expression." commit a0ae12ca91a45f81897e774019cde9bd081f03a0 Author: Connor Abbott <cwabbott0@gmail.com> Date: Thu Nov 29 17:46:59 2018 +0100 nir/algebraic: Add unit tests for bitsize validation The non-failure path can be tested by just compiling mesa and then testing it, but the failure paths won't be hit unless you make a mistake, so it's best to test them with some unit tests. Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-by: Dylan Baker <dylan@pnwbakers.com>