Bug 108376

Summary: Assert in piglit.spec.arb_fragment_program
Product: Mesa Reporter: Mark Janes <mark.a.janes>
Component: Drivers/DRI/i965Assignee: Kenneth Graunke <kenneth>
Status: RESOLVED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium Keywords: bisected, regression
Version: git   
Hardware: Other   
OS: All   
i915 platform: i915 features:

Description Mark Janes 2018-10-15 17:12:02 UTC
Bisected to:

Author:     Kenneth Graunke <kenneth@whitecape.org>
nir: Create sampler variables in prog_to_nir.

This is needed for nir_gather_info to actually count the textures,
since it operates solely on variables.

Following tests assert:

/tmp/build_root/m64/lib/piglit/bin/fp-fragment-position -auto -fbo

fp-fragment-position: ../src/mesa/drivers/dri/i965/brw_nir_uniforms.cpp:252: void brw_nir_setup_arb_uniforms(void*, nir_shader*, gl_program*, brw_stage_prog_data*): Assertion `shader->uniforms.length() <= 2' failed.
Comment 1 Mark Janes 2018-10-15 20:10:10 UTC
fixed by
Author:     Kenneth Graunke <kenneth@whitecape.org>

i965: Drop assert about number of uniforms in ARB handling.

My recent prog_to_nir patch started making new sampler uniforms, which
apparently increased the number of parameters.  We used to poke at the
one parameter directly, making it important that there was only one,
but we haven't done that in a while.  It should be safe to just delete
the assertion.

Fixes: 1c0f92d8a8c "nir: Create sampler variables in prog_to_nir."
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.