Bug 108178

Summary:	Move more test code to test/
Product:	dbus	Reporter:	Simon McVittie <smcv>
Component:	core	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED MOVED	QA Contact:	D-Bus Maintainers <dbus>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
URL:	https://gitlab.freedesktop.org/smcv/dbus-temp/merge_requests/2
Whiteboard:	review?
i915 platform:		i915 features:

Description Simon McVittie 2018-10-03 19:13:41 UTC

dbus currently has too much test code in bus/ and dbus/. This is awkward for several reasons:

* we need to compile the test binaries alongside the rest of bus/ and dbus/, but then run them from test/
* the test code gets counted as part of bus/ and dbus/ when computing coverage statistics, distorting our ideas about the coverage of the actual production code
* the "embedded tests" should not be compiled into libdbus and dbus-daemon when building secure, efficient production dbus binaries, but then we lose test coverage by disabling them
* the test framework used for the "embedded tests" makes it hard to skip tests that take forever and might not even be relevant to the bug/feature you're actually working on

This branch attempts to clean that up, removing something like half of the test code from dbus/, along with all the test executables.

Because I'm experimenting with freedesktop.org Gitlab ahead of dbus' migration, here's a merge request to review: https://gitlab.freedesktop.org/smcv/dbus-temp/merge_requests/2

(That's in a temporary clone of dbus, which I'll archive when we have the real dbus/dbus.git in Gitlab, and replace with a proper fork in smcv/dbus.)

Comment 1 GitLab Migration User 2018-10-12 21:36:23 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/dbus/dbus/issues/223.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.