Bug 107184

Summary: SyntaxError: Non-ASCII character '\xc2' in file tests/sanity.py on line 1, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
Product: piglit Reporter: Vinson Lee <vlee>
Component: infrastructureAssignee: Dylan Baker <baker.dylan.c>
Status: RESOLVED FIXED QA Contact: Piglit Mailing List <piglit>
Severity: normal    
Priority: medium CC: baker.dylan.c, jljusten
Version: unspecifiedKeywords: bisected, regression
Hardware: x86-64 (AMD64)   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2018-07-11 00:19:25 UTC 
Traceback (most recent call last):
  File "tests/serializer.py", line 151, in <module>
    main()
  File "tests/serializer.py", line 146, in main
    profile = load_test_profile(args.input, python=True)
  File "tests/../framework/profile.py", line 585, in load_test_profile
    mod = importlib.import_module('tests.{0}'.format(name))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "tests/sanity.py", line 1
SyntaxError: Non-ASCII character '\xc2' in file tests/sanity.py on line 1, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details


commit 8f0a5ed2140a535efde9f8f3e1f313e8094f23e8
Author: Dylan Baker <dylan@pnwbakers.com>
Date:   Tue Jul 3 10:07:14 2018 -0700

    tests/sanity: Rework sanity to be more useful
    
    Originally sanity was billed as a sort of "check if the installation
    works" sort of profile. No one seems to use sanity at all, so we'd like
    to re-purpose it (a little) to be a sort of "driver sanity" check, in
    other words, a minimal number of tests that are able to touch a broad
    swath of OpenGL features.
    
    Some of the things this touches now:
     - vertex shaders
     - fragment shaders
     - geometry shaders
     - tesselation shaders
     - compute shaders
     - transform feedback
     - ssbos
     - atomics
    
    Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Comment 1 Vinson Lee 2018-07-18 08:01:30 UTC 
commit 38860d93444bd4bd7e610fa5b491b6d85f702038
Author: Dylan Baker <dylan@pnwbakers.com>
Date:   Wed Jul 11 09:56:34 2018 -0700

    tests/sanity: declare encoding of file for python 2
    
    Python 2 assumes that files are encoded ascii unless they declare a
    different encoding, python 3 assumes files are encoded utf-8 unless they
    declare a different encoding.
    
    Tested-by: Vinson Lee <vlee@freedesktop.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.