Bug 1070

Summary: UseDeprecatedKeyboard should be TRUE on most OS'es
Product: xorg Reporter: Alan Coopersmith <alan.coopersmith>
Component: Input/KeyboardAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: high CC: kem
Version: git   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 351    
Attachments:
Description Flags
Patch to enable deprecated keyboard driver
none
New patch none

Description Alan Coopersmith 2004-08-13 09:30:58 UTC 
UseDeprecatedKeyboardDriver should be TRUE on most OS'es since the new keyboard
driver is not supported on them.

The simplest check for which OS'es it works on and doesn't seems to be seeing if
xf86OSKbdPreInit is a stub that just returns FALSE or actually inits the function
pointers in the OS'es directory under xc/programs/Xserver/hw/xfree86/os-support

A quick peek seems to show these implementations do have kbd driver support:

bsd/bsd_kbd.c
linux/lnx_kbd.c
os2/os2_kbd.c

and these do not:

bsdi/bsdi_io.c
dgux/dgux_io.c
hurd/hurd_io.c
lynxos/lynx_io.c
nto/nto_io.c
pmax/pmax_devs.c
qnx4/qnx_io.c
sco/sco_io.c
shared/kbd.c
sunos/sun_io.c
sysv/sysv_io.c

The fix proposed at release-wranglers was to change the default to YES and just
set NO for the platforms we know support it, at least for this release.
Comment 1 Kevin E. Martin 2004-08-13 11:23:13 UTC 
After thinking about this one some more, I think it might be better to keep the
default as NO, and explicitly enable the deprecated driver on systems that do no
yet support the new kbd driver.  This will help remind people that it is being
deprecated and additional support is needed.
Comment 2 Kristian Høgsberg 2004-08-13 14:20:58 UTC 
Created attachment 626 [details] [review]
Patch to enable deprecated keyboard driver

This patch sets UseDeprecatedKeyboardDriver to YES for those platforms that
doesn't support the new driver.  It keeps NO as the default.
Comment 3 Kristian Høgsberg 2004-08-13 14:35:20 UTC 
Created attachment 628 [details] [review]
New patch

Patch that doesn't break FreeBSD, add define for DGUX also.
Comment 4 Kevin E. Martin 2004-08-13 14:52:30 UTC 
The patch looks okay to me.  Alan?
Comment 5 Alan Coopersmith 2004-08-13 15:08:41 UTC 
Looks good to me too - not sure we got all the platforms, but I don't even know
that we've ever put together a complete list of platforms that the Xorg server
runs on.
Comment 6 Kristian Høgsberg 2004-08-14 17:59:13 UTC 
Patch committed.  I may not cover all platforms, but it does cover the platforms
that have a subdirectory in os-support.  If I've missed some platforms, we can
fix that in 6.8.1, and anyway it's just a matter of setting the #define in host.def.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.