Bug 106462

Summary: piglit.spec.arb_vertex_array_bgra.get regression
Product: Mesa Reporter: Mark Janes <mark.a.janes>
Component: Mesa coreAssignee: Brian Paul <brianp>
Status: RESOLVED FIXED QA Contact: mesa-dev
Severity: normal    
Priority: medium Keywords: bisected, regression
Version: git   
Hardware: Other   
OS: All   
i915 platform: i915 features:

Description Mark Janes 2018-05-10 15:11:59 UTC
Standard Output

/tmp/build_root/m64/lib/piglit/bin/arb_vertex_array_bgra-get -auto

Standard Error

glGetIntegerv(GL_COLOR_ARRAY_SIZE) returned 225, GL_BGRA expected
glGetIntegerv(GL_SECONDARY_COLOR_ARRAY_SIZE) returned 225, GL_BGRA expected

Bisected to:
Author:     Brian Paul <brianp@vmware.com>

mesa: fix glGetInteger/Float/etc queries for vertex arrays attribs

The vertex array Size and Stride attributes are now ubyte and short,
respectively.  The glGet code needed to be updated to handle those
types, but wasn't.

Fixes the new piglit test gl-1.5-get-array-attribs test.

v2: fix inadvertant whitespace change, change COLOR_ARRAY_SIZE to UBYTE,
misc fixes suggested by Justin

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106450
Fixes: d5f42f96e16 ("mesa: shrink size of gl_array_attributes (v2)")
Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: Mathias Fröhlich <mathias.froehlich@web.de>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Comment 1 Brian Paul 2018-05-10 15:53:32 UTC
Fixed by e4211b36bba4acde3e56ce1e22b12759e820a241

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.