| Summary: | cmake: Fix warning on travis-ci 'CMAKE_FORCE_C.._COMPILER macro is deprecated' | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Ralf Habacker <ralf.habacker> |
| Component: | core | Assignee: | D-Bus Maintainers <dbus> |
| Status: | RESOLVED FIXED | QA Contact: | D-Bus Maintainers <dbus> |
| Severity: | normal | ||
| Priority: | medium | CC: | ralf.habacker |
| Version: | unspecified | Keywords: | patch |
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
| Attachments: |
cmake: Fix warning on travis-ci 'CMAKE_FORCE_C.._COMPILER macro is deprecated'
cmake: Fix warning on travis-ci 'CMAKE_FORCE_C.._COMPILER macro is deprecated' |
||
|
Description
Ralf Habacker
2018-03-21 00:08:57 UTC
Created attachment 138231 [details] [review] cmake: Fix warning on travis-ci 'CMAKE_FORCE_C.._COMPILER macro is deprecated' CMake suggests to set CMAKE_C.._COMPILER instead and let allow CMake to identify the compiler. Bug: Comment on attachment 138231 [details] [review] cmake: Fix warning on travis-ci 'CMAKE_FORCE_C.._COMPILER macro is deprecated' Review of attachment 138231 [details] [review]: ----------------------------------------------------------------- Assuming it works, go ahead ::: cmake/i686-w64-mingw32.cmake @@ +11,3 @@ > set(MINGW TRUE) > > include(CMakeForceCompiler) With this change, is CMakeForceCompiler still needed? (In reply to Simon McVittie from comment #2) > Comment on attachment 138231 [details] [review] [review] > cmake: Fix warning on travis-ci 'CMAKE_FORCE_C.._COMPILER macro is > deprecated' > > Review of attachment 138231 [details] [review] [review]: > ----------------------------------------------------------------- > > Assuming it works, go ahead I tried that on travis-ci > > ::: cmake/i686-w64-mingw32.cmake > @@ +11,3 @@ > > set(MINGW TRUE) > > > > include(CMakeForceCompiler) > > With this change, is CMakeForceCompiler still needed? from the file #.rst: # CMakeForceCompiler # ------------------ # # Deprecated. Do not use. I would say yes. (In reply to Ralf Habacker from comment #3) > > With this change, is CMakeForceCompiler still needed? > > from the file > #.rst: > # CMakeForceCompiler > # ------------------ > # > # Deprecated. Do not use. > > I would say yes. sorry - I meant it could be removed Created attachment 138245 [details] [review] cmake: Fix warning on travis-ci 'CMAKE_FORCE_C.._COMPILER macro is deprecated' - remove obsolate include applied to master |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.