|Summary:||svga_screen.c:26:46: error: git_sha1.h: No such file or directory|
|Product:||Mesa||Reporter:||Vinson Lee <vlee>|
|Status:||RESOLVED FIXED||QA Contact:||mesa-dev|
|Priority:||medium||CC:||baker.dylan.c, fdo-bugs, jljusten|
|i915 platform:||i915 features:|
Description Vinson Lee 2017-10-28 09:25:52 UTC
mesa: 05592cebd4fd (master 17.4.0-devel) SCons build regression Compiling src/gallium/drivers/svga/svga_screen.c ... src/gallium/drivers/svga/svga_screen.c:26:46: error: git_sha1.h: No such file or directory commit 7088622e5fb506b64c906b673a9af0feb9a5ba14 Author: Eric Engestrom <firstname.lastname@example.org> Date: Wed Oct 25 14:04:35 2017 +0100 buildsys: move file regeneration logic to the script itself Signed-off-by: Eric Engestrom <email@example.com> Reviewed-by: Jordan Justen <firstname.lastname@example.org> Reviewed-by: Dylan Baker <email@example.com>
Comment 1 Brian Paul 2017-10-30 17:01:37 UTC
Hi Vinson, can you re-test with ToT? The scons build is working for me, testing at 134a40d2a67.
Comment 2 Dylan Baker 2017-10-30 17:07:57 UTC
I think Eric Engstrom sent a fix for this that's been reviewed but hasn't landed yet.
Comment 3 Eric Engestrom 2017-10-30 17:24:14 UTC
(In reply to Dylan Baker from comment #2) > I think Eric Engstrom sent a fix for this that's been reviewed but hasn't > landed yet. Indeed, I just pushed it: commit 2117d0331020874c28bb66b0596467f960259eb7 Author: Eric Engestrom <firstname.lastname@example.org> Date: Sun Oct 29 22:06:28 2017 +0000 git_sha1_gen: create empty file in fallback path I missed this part in my conversion, the old stream redirection meant the file was always created. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103496 Fixes: 7088622e5fb506b64c90 "buildsys: move file regeneration logic to the script itself" Signed-off-by: Eric Engestrom <email@example.com> Reviewed-by: Dylan Baker <firstname.lastname@example.org>
Comment 4 Ian Romanick 2017-10-30 22:25:50 UTC
I was just about to report the same bug... but 2117d033 seems to fix it for me. I'm going to close it. Vinson should reopen this bug if it's not fixed for him.