| Summary: | [llvmpipe] piglit fs-discard-exit-2 fails with llvm-6.0 | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Mesa core | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | mesa-dev |
| Severity: | normal | ||
| Priority: | medium | CC: | brianp, jfonseca, sroland |
| Version: | git | Keywords: | bisected |
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | patch accounting for llvm nuked pabs intrinsics | ||
|
Description
Vinson Lee
2017-09-28 18:23:03 UTC
Created attachment 134554 [details] [review] patch accounting for llvm nuked pabs intrinsics Does this patch work? I'm also changing the non-intrinsic definition of pabs to basically match what the auto-upgrader would do (if it would actually work for us...), so that llvm should be able to hopefully match that back to a pabs in the end (albeit the cmp/select has additional sext/trunc - I hope that doesn't matter...) - the old code would have used a max, which would have to be decomposed into a cmp/select too with newer llvm versions but it would have used select(cmp(greater, a, neg(a))) instead of select(cmp(greater, a, 0), neg(a)). Not sure if that would also get fused to a pabs instruction in the end... (In reply to Roland Scheidegger from comment #1) > Created attachment 134554 [details] [review] [review] > patch accounting for llvm nuked pabs intrinsics > > Does this patch work? > I'm also changing the non-intrinsic definition of pabs to basically match > what the auto-upgrader would do (if it would actually work for us...), so > that llvm should be able to hopefully match that back to a pabs in the end > (albeit the cmp/select has additional sext/trunc - I hope that doesn't > matter...) - the old code would have used a max, which would have to be > decomposed into a cmp/select too with newer llvm versions but it would have > used select(cmp(greater, a, neg(a))) instead of select(cmp(greater, a, 0), > neg(a)). Not sure if that would also get fused to a pabs instruction in the > end... Yes, this patch fixes the llvm.x86.avx2.pabs.d error. > Yes, this patch fixes the llvm.x86.avx2.pabs.d error.
Thanks for testing, fixed with 52b73caaf40e79c90a105ec6d349abb3398e3c6b.
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.