| Summary: | [BSW] image corruption issue after edd849e5448c4f6ddc04a5fa1ac5479176660c27 | ||
|---|---|---|---|
| Product: | DRI | Reporter: | freedesktop |
| Component: | DRM/Intel | Assignee: | JP <jp.guarrera> |
| Status: | CLOSED WORKSFORME | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Severity: | major | ||
| Priority: | high | CC: | intel-gfx-bugs, jp.guarrera |
| Version: | XOrg git | Keywords: | bisected |
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | ReadyForDev | ||
| i915 platform: | BSW/CHT | i915 features: | display/HDMI |
| Attachments: | |||
|
Description
freedesktop
2017-09-17 10:47:30 UTC
Created attachment 134287 [details]
drm.debug=0xe
Created attachment 134288 [details]
Xorg.0.log
Created attachment 134289 [details]
xrandr --verbose
Created attachment 134290 [details]
git bisect log
I don't see why git bisect wouldn't bisect into the merge. Care to check the last results again? > I don't see why git bisect wouldn't bisect into the merge. Sorry Jani, I'm not entirely sure what you mean here - I simply used "git bisect" between 4.11.10 (known good) and 4.12-rc1 (known bad), and based on testing of the resulting kernels git decided that the merge commit was the bad commit. Can you tell me the best way to bisect the merge commit and I'll give that a go. My kernel repo is a clone of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git > Care to check the last results again? I'll ask the user to check the builds again, there were 14 in total. This may take a few days. Unfortunately I can't reproduce this issue myself. Does the dmesg cover the part where the user sees flickering? Created attachment 134407 [details]
single frame from the video exhibiting the issue
Created attachment 134408 [details] dmesg that includes period when image artifacts appeared Quote from user: "dmesg | pastebinit -> http://sprunge.us/cTFK & the issues are reproduced ~20 times during 2min !!!" So it would appear that when these events occur, nothing is being logged... I used git to bisect between v4.12-rc1 (BAD) and v4.11.10 (GOOD). Unfortunately git identified a merge commit as the BAD commit: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/patch/?id=edd849e5448c4f6ddc04a5fa1ac5479176660c27 and would not bisect any further. I decided to "bisect" manually, and having done so the first BAD commit is: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/patch/?id=608b20506941969ea30d8c08dc9ae02bb87dbf7d By reverting 608b20506941969ea30d8c08dc9ae02bb87dbf7d from 4.13.3 (see attached patch), the user has confirmed that 4.13.3 is now GOOD, while the normal 4.13.3 (without the revert) is still BAD. I'll attach the "revert" patch (which is just for test purposes), and also my steps taken to confirm this conclusion (just for completeness) Created attachment 134562 [details] [review] Reverting 608b20506941969ea30d8c08dc9ae02bb87dbf7d for use with 4.13.3 Created attachment 134563 [details]
Steps to confirm that 608b20506941969ea30d8c08dc9ae02bb87dbf7d is BAD
Dears, I'm the originator of this bug. I start my own company and after several researches I decided to base my products on intel platform ( instead of Amlogx, imx,...) I try to offer to end user and complete personal DVBT/DVBS streaming solution To reach this target , my company is developping the client & server by ourself ( at limited costs ) I'm now in blocked state due to the above bug. May I ask you kindly to review it & let me know if there is chance to found some solution. Otherwise, I 'll be forced to switch from intel to other platform ( I know it's technical the best ... but ... project / results first ) Thanks a lot in advance JP Project Manager Reopening since information requested in comment #5 and comment #7 has been provided. Good afternoon JP. If your company has an agreement with Intel please use proper internal channels to speed this up, otherwise allow us to review further. Hi Elizabeth As I wrote I'm small company with limited budget Unfortunatelly I don't have any agreement with Intel I just count from now on developpers devotion... Thanks in advance JP (In reply to freedesktop from comment #10) > By reverting 608b20506941969ea30d8c08dc9ae02bb87dbf7d from 4.13.3 (see > attached patch), the user has confirmed that 4.13.3 is now GOOD, while the > normal 4.13.3 (without the revert) is still BAD. 608b20506941 ("drm: Defer disabling the vblank IRQ until the next interrupt (for instant-off)") Created attachment 134760 [details] [review] Hold powerwell for vblanks Something like this? Hi Chris. Unfortunately the patch hasn't helped - JP has tested a build based on 4.13.5 + your patch from comment #17, and he has the same Z display corruption as before. Hi Any update on the previous topic ? thanks in advance JP We have a bunch of bugfixes all over in flight, please reteste with latest drm-tip (and quote the full top commit of it, it's a rebasing tree, the sha1 isn't useful). Both with and without Chris' patch. Also note: PSR will break the vblank code, pls make sure you don't have that enabled somewhere in the module options. Hi, apologies for the long delay - a bad case of Man Flu has knocked me out for the past week. On Sunday I produced three test builds for JP based on drm-tip[1]: "drm-tip: 2017y-11m-12d-14h-36m-14s UTC integration manifest" The three builds were: #1113b: drmtip only #1113c: #1113b + Chris Wilson patch (comment 17) #1113d: #1113b + my hack patch (comment 11) After testing, JP has called all three builds as "GOOD", as none are exhibiting the Z-shaped corruption. Therefore it doesn't look like any additional patches from this bug are required. However a different build (exact same userland but with drm-tip replaced by the mainline 4.14 kernel released on Sunday, and no patches from this bug) continues to show the Z-shaped corruption, so the corruption issue is still present in the mainline 4.14 kernel. Maybe this issue will be fixed in 4.15? 1. https://cgit.freedesktop.org/drm-tip/commit/?id=0dc48f1fad834c3ab95f4d178e9e38e6ea39b6cf Oh and there are no PSR (Panel Self Refresh) settings enabled to my knowledge. Dears, it appears bug solved in the 4.15rc1 I 'll close the bug when the test will be also positive for the 4.15.0 Thanks for al JP First of all. Sorry about spam. This is mass update for our bugs. Sorry if you feel this annoying but with this trying to understand if bug still valid or not. If bug investigation still in progress, please ignore this and I apologize! If you think this is not anymore valid, please comment to the bug that can be closed. If you haven't tested with our latest pre-upstream tree(drm-tip), can you do that also to see if issue is valid there still and if you cannot see issue there, please comment to the bug. Closing, please re-open if still occurs. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.