Bug 1026

Summary:	Xnest is missing XKB on BuildServersOnly
Product:	xorg	Reporter:	Alexander Gottwald <ago>
Component:	Server/DDX/Xnest	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	high	CC:	kem
Version:	git
Hardware:	x86 (IA32)
OS:	Windows (All)
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	351

Description Alexander Gottwald 2004-08-10 04:33:26 UTC

Xnest will not compile on cygwin because of missing _XKBFreeKeyboard symbols
from libX11. The xorg server is not affected since BuildXKBlib is set in xorg.cf

from X11.tmpl:

#ifndef BuildXKBlib
#define BuildXKBlib		(BuildXKB && !BuildServersOnly)
#endif

fix: 

#ifndef BuildXKBlib
#define BuildXKBlib		(BuildXKB && (!BuildServersOnly || XnestServer))
#endif

Comment 1 Kevin E. Martin 2004-08-10 20:53:06 UTC

For systems that use xorg.cf, BuildXKBLib is enabled, unless explicitly disabled
in the host.def file.  I think this will be a problem with building DMX on other
systems as well.

Perhaps it should be:

#ifndef BuildXKBlib
#define BuildXKBlib		(BuildXKB && (!BuildServersOnly || \\
					      XnestServer || XdmxServer))
#endif

Comment 2 Kevin E. Martin 2004-08-11 16:02:37 UTC

Patch checked in.  Closing.

Comment 3 Kevin E. Martin 2004-08-11 16:03:05 UTC

Actually close it this time...

Comment 4 Alexander Gottwald 2004-08-12 02:35:16 UTC

#ifndef BuildXKBlib
#define BuildXKBlib		(BuildXKB && (!BuildServersOnly || \\
					      XnestServer || XdmxServer))
#endif

I've problems with the \\ at the end. Shouldn't it be a single backslash?

$ make Makefile
+ rm -f Makefile.bak
+ mv -f Makefile Makefile.bak
../../config/imake/imake -I../../config/cf   -DTOPDIR=../.. -DCURDIR=lib/Xcomposite
In file included from ../../config/cf/Imake.tmpl:2129,
                 from Imakefile.c:9:
../../config/cf/X11.tmpl:3705: invalid character '\' in #if
../../config/cf/X11.tmpl:3742: invalid character '\' in #if
../../config/cf/X11.tmpl:3777: invalid character '\' in #if
../../config/imake/imake: Exit code 1.
  Stop.
make: *** [Makefile] Error 1

Comment 5 Kristian Høgsberg 2004-08-12 06:09:18 UTC

Fixed in cvs, just a typo.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.