Bug 102155

Created attachment 133444 [details] [review]
[PATCH] Use generic text icon for application/sql

The attached patch would fix this bug.

$ pwd
/usr/share/mime/application
$ grep '<sub-class-of type="text/plain"/>' * | wc -l
56

I think we're half-expecting the mime engine to look at those mime-types and assign them a text "generic icon" when it sees that it's a sub-class of text/plain.

Either we need to check whether xdg-mime implementations already do this, and mention it in the spec, or fix it up for all the mime-types, not just application/sql.

I searched through freedesktop.org.xml.in and the only application media types that inherit from text/plain and do not specify an icon are:

application/sql - Should use the generic text icon

application/vnd.apple.mpegurl - Should NOT use the generic text icon because even though this is a text format, these files open in an audio or video player

application/x-trig - Should use the generic text icon

It really wouldn't be hard to explicitly specify the icon for application/sql and application/x-trig, like we do for dozens of other types that inherit from text/plain.

By the way, you can see that the wrong icons are being used now just by running `touch test.sql test.trig test.txt` and looking at those files in your graphical file browser.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xdg/shared-mime-info/issues/37.