| Summary: | specular light calculation wrong when LIGHT_MODEL_LOCAL_VIEWER is true | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | WuNian <nian.wu> |
| Component: | Drivers/DRI/i965 | Assignee: | Eric Anholt <eric> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | haihao.xiang, mesa-dev, wei.z.wang |
| Version: | git | ||
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
test case
re-calculating the half |
||
|
Description
WuNian
2007-03-05 18:26:49 UTC
Created attachment 8991 [details]
test case
Created attachment 9032 [details] [review] re-calculating the half According to the gl spec, the half is different from other when local view is enabled and the light is a directional source. The patch works for us. Please remove the content in patch: diff --git a/configs/default b/configs/default.... Could anyone review this fix? If no problem, I will check in it. Looks good to me. Should probably be fixed in t_vp_build.c (used by other drivers) too (though I have to admit last time I did some changes there I missed the i965 driver because I didn't realize it has the same code). fixed. commit 61ec23cc63a040a2edf1bc466917e85362514c89 thanks for Roland's review and comments Mass version move, cvs -> git |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.