| Summary: | Fix integration test issues | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Simon McVittie <smcv> |
| Component: | core | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | D-Bus Maintainers <dbus> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
| Attachments: |
AppArmor test: Allow writing to our temporary XDG_RUNTIME_DIR
transient-services integration test: Create the right directory Ensure hyphen/minus is treated as literal in regexes |
||
|
Description
Simon McVittie
2017-04-14 18:40:16 UTC
Created attachment 130846 [details] [review] AppArmor test: Allow writing to our temporary XDG_RUNTIME_DIR Created attachment 130847 [details] [review] transient-services integration test: Create the right directory Created attachment 130848 [details] [review] Ensure hyphen/minus is treated as literal in regexes Each U+002D HYPHEN-MINUS in [0-9A-Za-z_-/.\] is treated as a member of a range. The third one, which appears to have been intended to be a literal, is part of an empty range because the starting point U+005F LOW LINE is greater than the endpoint U+002F SOLIDUS, resulting in at least some grep implementations not considering U+002D, U+002F or U+005F to match the pattern. This resulted in one of the dbus-launch tests being unintentionally skipped when it used a regex based on the one in the spec. regex(7) suggests "To include a literal '-' [in a bracketed character set], make it the first or last character". Comment on attachment 130846 [details] [review] AppArmor test: Allow writing to our temporary XDG_RUNTIME_DIR Review of attachment 130846 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 130847 [details] [review] transient-services integration test: Create the right directory Review of attachment 130847 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 130848 [details] [review] Ensure hyphen/minus is treated as literal in regexes Review of attachment 130848 [details] [review]: ----------------------------------------------------------------- This is wonderously esoteric. ++ Fixed in git for 1.11.14, thanks |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.