Bug 100154

Summary:	test_eu_compact regression
Product:	Mesa	Reporter:	Vinson Lee <vlee>
Component:	Drivers/DRI/i965	Assignee:	Matt Turner <mattst88>
Status:	RESOLVED FIXED	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	normal
Priority:	medium	CC:	jason
Version:	git	Keywords:	bisected, regression
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Vinson Lee 2017-03-11 07:05:57 UTC

mesa: fa4b792e833a5b9a74d21ca72babeeebc72fd052 (master 17.1.0-devel)

set_control_index (devinfo=0x630c20, src=0x7fffffffdf40, dst=0x7fffffffdf10) at brw_eu_compact.c:692
692	      if (control_index_table[i] == uncompacted) {
(gdb) print control_index_table
$1 = (const uint32_t *) 0x0


commit fa4b792e833a5b9a74d21ca72babeeebc72fd052
Author: Matt Turner <mattst88@gmail.com>
Date:   Thu Mar 9 16:01:30 2017 -0800

    i965: Move brw_init_compaction_tables() to brw_create_compiler().
    
    ... so that we can avoid threading complications or unnecessary
    compaction table initializations (which just consists of setting some
    pointers based on devinfo->gen).
    
    Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>

Comment 1 Matt Turner 2017-03-11 07:17:39 UTC

Thanks for the heads up!

Fixed by

commit 3d253d330a47eb06bd4745c3ee41c4aa9d6143be
Author: Matt Turner <mattst88@gmail.com>
Date:   Fri Mar 10 23:15:33 2017 -0800

    i965: Initialize compaction tables in unit test.
    
    Fixes: fa4b792e833a "i965: Move brw_init_compaction_tables() to brw_create_compiler()."
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100154

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.