Bug 33870:
lack of clarity in dbus-marshal-recursive.c: can type_str be NULL? -
Simon McVittie <smcv@collabora.com> -
2/3/2011
Back to Bug |
Your Reviews |
Help
Attachment 51353:
[7/9 v2] _dbus_type_writer_init: do not allow initialization without type_str -
Simon McVittie <smcv@collabora.com> -
9/19/2011
(
View
)
Close Quick Help
- From the Overview page, you can add a more generic overview comment that will appear at the beginning of your review.
- To comment on a specific lines in the patch, first select the filename from the file navigation links.
- Then double click the line you want to review and a comment box will appear below the line.
- When the review is complete and you publish it, the overview comment and all line specific comments with their context,
will be combined together into a single review comment on the bug report.
- For more detailed instructions, read the Splinter
help page.
From: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: Fri, 10 Jun 2011 14:00:19 +0100
Subject: [PATCH 7/9] _dbus_type_writer_init: do not allow initialization
without type_str
Also assert about other preconditions, for clarity.
(Restored from draft; last edited )