Bug 36134: TpProtocol claims it doesn't support any extra iface - Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> - 4/11/2011 Back to Bug | Your Reviews | Help
Attachment 45524: More use tp_proxy_add_interfaces() - Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> - 4/12/2011 (View )

Show Quick Help

From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: Mon, 11 Apr 2011 17:31:27 +0200
Subject: [PATCH] More use tp_proxy_add_interfaces()
<Overall Comment>
Previous Reviews
Will Thompson <will@willthompson.co.uk>
4/12/2011
“More use tp_proxy_add_interfaces” isn't English.
“Use tp_proxy_add_interfaces() more [widely]” is.
telepathy-glib/account.c
466 gboolean presence_changed = FALSE;
467 const gchar * const *interfaces;
468 
469 interfaces = tp_asv_get_boxed (properties, "Interfaces", G_TYPE_STRV);
470 tp_proxy_add_interfaces (proxy, interfaces);
This could even become
tp_proxy_add_interfaces (proxy, tp_asv_get_strv (properties, "Interfaces"));
telepathy-glib/connection-manager.c
708tp_connection_manager_add_interfaces (TpConnectionManager *self,
709 const gchar * const * interfaces)
This function doesn't do anything else, and isn't API, so just delete it?
Powered by Splinter

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.