Bug 101354: Minimal version of restricted, identifiable bus servers for containers (#100344) - Simon McVittie <smcv@collabora.com> - 6/8/2017 Back to Bug | Your Reviews | Help
Attachment 133018: test/containers: Exercise a successful call to AddServer - Simon McVittie <smcv@collabora.com> - 7/26/2017 (View )

Show Quick Help

From: Simon McVittie <smcv@collabora.com>
Date: Tue, 20 Jun 2017 15:55:53 +0100
Subject: [PATCH] test/containers: Exercise a successful call to AddServer
Signed-off-by: Simon McVittie <smcv@collabora.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=101354
---
test/containers.c | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 172 insertions(+)
<Overall Comment>
Previous Reviews
Philip Withnall <bugzilla@tecnocode.co.uk>
7/31/2017
-----------------------------------------------------------------
r-, type safety bug which doesn’t affect correctness.
test/containers.c
154 * system infrastructure to create; so it's OK for AddServer to fail
155 * when uninstalled, although not OK if it fails as an installed-test. */
156 if (f->error != NULL &&
157 _dbus_getuid () == 0 &&
158 _dbus_getenv ("DBUS_TEST_UNINSTALLED") != 0)
_dbus_getenv() returns a const char*, not an int.
Powered by Splinter

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.