Bug 101568: Add a way to store single items from messages - Simon McVittie <smcv@collabora.com> - 6/23/2017 Back to Bug | Your Reviews | Help
Attachment 132427: [01] _dbus_marshal_validate_test: Merge two sets of signature validity checks - Simon McVittie <smcv@collabora.com> - 7/4/2017 (View )

Show Quick Help

From: Simon McVittie <smcv@collabora.com>
Date: Tue, 4 Jul 2017 17:00:59 +0100
Subject: [PATCH 05/19] _dbus_marshal_validate_test: Merge two sets of
signature validity checks
The deleted lines used to be a test for _dbus_validate_signature(),
until I deleted that function. We also had a completely separate
test for _dbus_validate_signature_with_reason() which remains present.
Some of the test vectors were tested in both places.
Signed-off-by: Simon McVittie <smcv@collabora.com>
---
dbus/dbus-marshal-validate-util.c | 62 ++++++---------------------------------
1 file changed, 9 insertions(+), 53 deletions(-)
<Overall Comment>
Previous Reviews
Philip Withnall <bugzilla@tecnocode.co.uk>
7/5/2017
-----------------------------------------------------------------
A+, a delightful cleanup, would clean up again.
Powered by Splinter

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.