Attachment 39752 Details for Bug 31093 – The patch

[patch] The patch

0001-Integer-overflow-for-dashed-lines-longer-than-46340.patch (text/plain), 1.04 KB, created by Siddhesh Poyarekar on 2010-10-24 22:51:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Siddhesh Poyarekar

Created: 2010-10-24 22:51:36 UTC

Size: 1.04 KB

patch

obsolete

>From 131c579b2c4e41fd4e80b2568b36fc329c143757 Mon Sep 17 00:00:00 2001
>From: Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com>
>Date: Mon, 25 Oct 2010 11:08:19 +0530
>Subject: [PATCH] Integer overflow for dashed lines longer than 46340
>
>Lines of length greater than 46340 can be drawn with one of the
>coordinates being negative. However, miPolyBuildPoly overflows the int
>type when setting up edges for a section of the dashed line. This fix
>casts the results into long long so that the numbers don't wrap around
>and result in the line not being drawn at all.
>---
> mi/miwideline.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/mi/miwideline.c b/mi/miwideline.c
>index b11b40b..8a1567e 100644
>--- a/mi/miwideline.c
>+++ b/mi/miwideline.c
>@@ -403,7 +403,7 @@ miPolyBuildPoly (
>     i = top;
>     j = StepAround (top, -1, count);
> 
>-    if (slopes[j].dy * slopes[i].dx > slopes[i].dy * slopes[j].dx)
>+    if ((long long)slopes[j].dy * slopes[i].dx > (long long)slopes[i].dy * slopes[j].dx)
>     {
> 	clockwise = -1;
> 	slopeoff = -1;
>-- 
>1.7.2.3
>

Actions: View | Splinter Review

Attachments on bug 31093: 39752 | 39753

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.