From 1178f4f4f4dceb79b37e70cc109aa41a85833402 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Thu, 28 Sep 2017 13:18:11 +0100 Subject: [PATCH 2/3] dbus: Clarify why we are not just adding the resource file to SOURCES Signed-off-by: Simon McVittie --- dbus/Makefile.am | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dbus/Makefile.am b/dbus/Makefile.am index 8248e72e..064d4152 100644 --- a/dbus/Makefile.am +++ b/dbus/Makefile.am @@ -47,12 +47,17 @@ SUFFIXES = .rc .rc.o: $(WINDRES) $< -o $@ +# We can't just put versioninfo.rc in SOURCES and let Automake infer +# how to make versioninfo.o, because libtool wants libtool objects (.lo), +# not plain COFF objects (.o). Add it to the linker command explicitly +# instead. dbus_res = versioninfo.o +EXTRA_libdbus_1_la_DEPENDENCIES = $(dbus_res) dbus_res_ldflag = -Wl,$(dbus_res) + no_undefined = -no-undefined export_symbols = -EXTRA_libdbus_1_la_DEPENDENCIES = $(dbus_res) intllibs = else -- 2.14.2