From cf2da2540be752eaa018711b16c30c6d98b12969 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Wed, 5 Apr 2017 11:35:27 +0100 Subject: [PATCH] test: Fix reading off the end of an array in test-corrupt One level of pointer indirection too many when passing the arguments to dbus_message_append_args(). https://bugs.freedesktop.org/show_bug.cgi?id=100568 Signed-off-by: Philip Withnall --- test/corrupt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/corrupt.c b/test/corrupt.c index d106fcc..56a0cdf 100644 --- a/test/corrupt.c +++ b/test/corrupt.c @@ -271,7 +271,6 @@ test_byte_order (Fixture *f, int fd; char *blob; const gchar *arg = not_a_dbus_message; - const gchar * const *args = &arg; int blob_len; DBusMessage *message; dbus_bool_t mem; @@ -283,7 +282,7 @@ test_byte_order (Fixture *f, /* Append 0xFF bytes, so that the length of the body when byte-swapped * is 0xFF000000, which is invalid */ mem = dbus_message_append_args (message, - DBUS_TYPE_ARRAY, DBUS_TYPE_BYTE, &args, 0xFF, + DBUS_TYPE_ARRAY, DBUS_TYPE_BYTE, &arg, 0xFF, DBUS_TYPE_INVALID); g_assert (mem); mem = dbus_message_marshal (message, &blob, &blob_len); -- 2.9.3