Attachment 129473 Details for Bug 99758 – dbus-object-tree: Correctly report failure from an internal test

[patch] dbus-object-tree: Correctly report failure from an internal test

dbus-object-tree-Correctly-report-failure-from-an-.patch (text/plain), 1.06 KB, created by Philip Withnall on 2017-02-10 11:07:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philip Withnall

Created: 2017-02-10 11:07:54 UTC

Size: 1.06 KB

patch

obsolete

>From c59e046cefe96669b25856b78314b87fa938b47a Mon Sep 17 00:00:00 2001
>From: Philip Withnall <withnall@endlessm.com>
>Date: Fri, 10 Feb 2017 11:05:21 +0000
>Subject: [PATCH] dbus-object-tree: Correctly report failure from an internal
> test
>
>Coverity ID: 54711
>
>Signed-off-by: Philip Withnall <withnall@endlessm.com>
>
>https://bugs.freedesktop.org/show_bug.cgi?id=99758
>---
> dbus/dbus-object-tree.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
>diff --git a/dbus/dbus-object-tree.c b/dbus/dbus-object-tree.c
>index afbd61f..77a4225 100644
>--- a/dbus/dbus-object-tree.c
>+++ b/dbus/dbus-object-tree.c
>@@ -2315,11 +2315,9 @@ object_tree_test_iteration (void *data)
> dbus_bool_t
> _dbus_object_tree_test (void)
> {
>-  _dbus_test_oom_handling ("object tree",
>-                           object_tree_test_iteration,
>-                           NULL);
>-
>-  return TRUE;
>+  return _dbus_test_oom_handling ("object tree",
>+                                  object_tree_test_iteration,
>+                                  NULL);
> }
> 
> #endif /* !DOXYGEN_SHOULD_SKIP_THIS */
>-- 
>2.9.3

Actions: View | Splinter Review

Attachments on bug 99758: 129473 | 129556

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.