Attachment 119208 Details for Bug 92298 – attachment-24989-0.html

attachment-24989-0.html

attachment-24989-0.html (text/html), 3.61 KB, created by Ralf Habacker on 2015-10-26 22:30:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Habacker

Created: 2015-10-26 22:30:55 UTC

Size: 3.61 KB

patch

obsolete

><html>
>  <head>
>    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
>  </head>
>  <body bgcolor="#FFFFFF" text="#000000">
>    <br>
>    <br>
>    <div class="moz-cite-prefix">Am 26.10.2015 um 13:51 schrieb
>      <a class="moz-txt-link-abbreviated" href="mailto:bugzilla-daemon@freedesktop.org">bugzilla-daemon@freedesktop.org</a>:<br>
>    </div>
>    <blockquote
>      cite="mid:bug-92298-6128-cR35H12hog@http.bugs.freedesktop.org%2F"
>      type="cite"> <base href="https://bugs.freedesktop.org/"> <span
>        class="vcard"><a moz-do-not-send="true" class="email"
>          href="mailto:simon.mcvittie@collabora.co.uk" title="Simon
>          McVittie &lt;simon.mcvittie@collabora.co.uk&gt;"> <span
>            class="fn">Simon McVittie</span></a>
>      </span> changed <a moz-do-not-send="true" class="bz_bug_link
>        bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - DBus
>        session bus crashes due to specially crafted call of
>        'dbus-monitor'"
>        href="https://bugs.freedesktop.org/show_bug.cgi?id=92298">bug
>        92298</a> <br>
>      <table border="1" cellpadding="8" cellspacing="0">
>        <tbody>
>          <tr>
>            <th>What</th>
>            <th>Removed</th>
>            <th>Added</th>
>          </tr>
>          <tr>
>            <td style="text-align:right;">Status</td>
>            <td>ASSIGNED </td>
>            <td>RESOLVED </td>
>          </tr>
>          <tr>
>            <td style="text-align:right;">Resolution</td>
>            <td>--- </td>
>            <td>FIXED </td>
>          </tr>
>        </tbody>
>      </table>
>      <p> </p>
>      <div> <b><a moz-do-not-send="true" class="bz_bug_link
>            bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - DBus
>            session bus crashes due to specially crafted call of
>            'dbus-monitor'"
>            href="https://bugs.freedesktop.org/show_bug.cgi?id=92298#c26">Comment
>            # 26</a> on <a moz-do-not-send="true" class="bz_bug_link
>            bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - DBus
>            session bus crashes due to specially crafted call of
>            'dbus-monitor'"
>            href="https://bugs.freedesktop.org/show_bug.cgi?id=92298">bug
>            92298</a> from <span class="vcard"><a
>              moz-do-not-send="true" class="email"
>              href="mailto:simon.mcvittie@collabora.co.uk" title="Simon
>              McVittie &lt;simon.mcvittie@collabora.co.uk&gt;"> <span
>                class="fn">Simon McVittie</span></a>
>          </span></b>
>        <pre>(In reply to Simon McVittie from <a moz-do-not-send="true" href="show_bug.cgi?id=92298#c20">comment #20</a>)
><span class="quote">&gt; Created <span class=""><a moz-do-not-send="true" href="attachment.cgi?id=119027" name="attach_119027" title="Add a regression test for invalid BecomeMonitor calls">attachment 119027</a> <a moz-do-not-send="true" href="attachment.cgi?id=119027&amp;action=edit" title="Add a regression test for invalid BecomeMonitor calls">[details]</a></span> <a moz-do-not-send="true" href="page.cgi?id=splinter.html&amp;bug=92298&amp;attachment=119027">[review]</a>
>&gt; Add a regression test for invalid BecomeMonitor calls</span>
>
>I've applied this unreviewed, because it doesn't affect the non-test parts of
>D-Bus, nobody has said no, and test &gt; no test.</pre>
>      </div>
>    </blockquote>
>    Unfortunally you applied the outdated patch, which results into
>    compile errors.Â  The correct patch is
>    <a class="moz-txt-link-freetext" href="https://bugs.freedesktop.org/attachment.cgi?id=119027">https://bugs.freedesktop.org/attachment.cgi?id=119027</a><br>
>    <br>
>    Regards<br>
>    Â Ralf<br>
>    <br>
>  </body>
></html>
>

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    <br>
    <div class="moz-cite-prefix">Am 26.10.2015 um 13:51 schrieb
      <a class="moz-txt-link-abbreviated" href="mailto:bugzilla-daemon@freedesktop.org">bugzilla-daemon@freedesktop.org</a>:<br>
    </div>
    <blockquote
      cite="mid:bug-92298-6128-cR35H12hog@http.bugs.freedesktop.org%2F"
      type="cite"> <base href="https://bugs.freedesktop.org/"> <span
        class="vcard"><a moz-do-not-send="true" class="email"
          href="mailto:simon.mcvittie@collabora.co.uk" title="Simon
          McVittie &lt;simon.mcvittie@collabora.co.uk&gt;"> <span
            class="fn">Simon McVittie</span></a>
      </span> changed <a moz-do-not-send="true" class="bz_bug_link
        bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - DBus
        session bus crashes due to specially crafted call of
        'dbus-monitor'"
        href="https://bugs.freedesktop.org/show_bug.cgi?id=92298">bug
        92298</a> <br>
      <table border="1" cellpadding="8" cellspacing="0">
        <tbody>
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>
          <tr>
            <td style="text-align:right;">Status</td>
            <td>ASSIGNED </td>
            <td>RESOLVED </td>
          </tr>
          <tr>
            <td style="text-align:right;">Resolution</td>
            <td>--- </td>
            <td>FIXED </td>
          </tr>
        </tbody>
      </table>
      <p> </p>
      <div> <b><a moz-do-not-send="true" class="bz_bug_link
            bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - DBus
            session bus crashes due to specially crafted call of
            'dbus-monitor'"
            href="https://bugs.freedesktop.org/show_bug.cgi?id=92298#c26">Comment
            # 26</a> on <a moz-do-not-send="true" class="bz_bug_link
            bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - DBus
            session bus crashes due to specially crafted call of
            'dbus-monitor'"
            href="https://bugs.freedesktop.org/show_bug.cgi?id=92298">bug
            92298</a> from <span class="vcard"><a
              moz-do-not-send="true" class="email"
              href="mailto:simon.mcvittie@collabora.co.uk" title="Simon
              McVittie &lt;simon.mcvittie@collabora.co.uk&gt;"> <span
                class="fn">Simon McVittie</span></a>
          </span></b>
        <pre>(In reply to Simon McVittie from <a moz-do-not-send="true" href="show_bug.cgi?id=92298#c20">comment #20</a>)
<span class="quote">&gt; Created <span class=""><a moz-do-not-send="true" href="attachment.cgi?id=119027" name="attach_119027" title="Add a regression test for invalid BecomeMonitor calls">attachment 119027</a> <a moz-do-not-send="true" href="attachment.cgi?id=119027&amp;action=edit" title="Add a regression test for invalid BecomeMonitor calls">[details]</a></span> <a moz-do-not-send="true" href="page.cgi?id=splinter.html&amp;bug=92298&amp;attachment=119027">[review]</a>
&gt; Add a regression test for invalid BecomeMonitor calls</span>

I've applied this unreviewed, because it doesn't affect the non-test parts of
D-Bus, nobody has said no, and test &gt; no test.</pre>
      </div>
    </blockquote>
    Unfortunally you applied the outdated patch, which results into
    compile errors.Â  The correct patch is
    <a class="moz-txt-link-freetext" href="https://bugs.freedesktop.org/attachment.cgi?id=119027">https://bugs.freedesktop.org/attachment.cgi?id=119027</a><br>
    <br>
    Regards<br>
    Â Ralf<br>
    <br>
  </body>
</html>

Actions: View

Attachments on bug 92298: 118708 | 118709 | 118710 | 119026 | 119027 | 119208

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.