Attachment 88305 Details for Bug 54875 – fixup! Default account backend: store each account as a stringified GVariant in a file

[patch] fixup! Default account backend: store each account as a stringified GVariant in a file

0001-fixup-Default-account-backend-store-each-account-as-.patch (text/plain), 1.09 KB, created by Simon McVittie on 2013-10-29 16:10:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-10-29 16:10:12 UTC

Size: 1.09 KB

patch

obsolete

>From 462f1519f3b86854041357402c66dc67333eb12e Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 29 Oct 2013 16:07:32 +0000
>Subject: [PATCH] fixup! Default account backend: store each account as a
> stringified GVariant in a file
>
>Don't leak @other.
>---
> src/mcd-account-manager-default.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/src/mcd-account-manager-default.c b/src/mcd-account-manager-default.c
>index 5da0e50..4dc0e8b 100644
>--- a/src/mcd-account-manager-default.c
>+++ b/src/mcd-account-manager-default.c
>@@ -424,8 +424,11 @@ am_default_commit_one (McdAccountManagerDefault *self,
>           iter++)
>         {
>           gchar *other = account_file_in (*iter, account_name);
>+          gboolean other_exists = g_file_test (other, G_FILE_TEST_EXISTS);
> 
>-          if (g_file_test (other, G_FILE_TEST_EXISTS))
>+          g_free (other);
>+
>+          if (other_exists)
>             {
>               /* There is a lower-priority file that would provide this
>                * account. We can't delete a file from XDG_DATA_DIRS which
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 54875: 88294 | 88295 | 88296 | 88297 | 88298 | 88299 | 88300 | 88305

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.