Attachment 86452 Details for Bug 65415 – [PATCH] Do not suggest user the next step after executed autogen.sh

[patch] [PATCH] Do not suggest user the next step after executed autogen.sh

0001-Do-not-suggest-user-the-next-step-after-executed-aut.patch (text/plain), 1.20 KB, created by Chengwei Yang on 2013-09-24 13:35:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chengwei Yang

Created: 2013-09-24 13:35:28 UTC

Size: 1.20 KB

patch

obsolete

>From 824dc089b3f2be431bc894a1d381ce57aa34347e Mon Sep 17 00:00:00 2001
>From: Chengwei Yang <chengwei.yang@intel.com>
>Date: Tue, 24 Sep 2013 21:25:01 +0800
>Subject: [PATCH] Do not suggest user the next step after executed autogen.sh
>
>We assume that user/developer who building dbus from source code are
>familiar with the standard 'autogen.sh, configure, make, make install'
>build process, so print such a notice doesn't make a lot of sense.
>
>In addition, on *BSD platform, the pre-installed 'make' doesn't work at
>all since gnu make is required. However, it named to 'gmake' on *BSD
>platform. So the notice will makes new comer confused.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65415
>---
> autogen.sh |    8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
>diff --git a/autogen.sh b/autogen.sh
>index b049f4e..fe8dd37 100755
>--- a/autogen.sh
>+++ b/autogen.sh
>@@ -101,11 +101,5 @@ else
> fi
> 
> if $run_configure; then
>-    $srcdir/configure --enable-developer --config-cache "$@" || exit $?
>-    echo 
>-    echo "Now type 'make' to compile $PROJECT."
>-else
>-    echo
>-    echo "Now run 'configure' and 'make' to compile $PROJECT."
>+    $srcdir/configure --enable-developer --config-cache "$@"
> fi
>-
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 65415: 80343 | 80379 | 86452

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.